Skip to content

[infra] Add CUDA version check for USE_CUNLS - #75

Open
slepichev wants to merge 1 commit into
mainfrom
slepichev/cunls-cuda-version-check
Open

[infra] Add CUDA version check for USE_CUNLS#75
slepichev wants to merge 1 commit into
mainfrom
slepichev/cunls-cuda-version-check

Conversation

@slepichev

@slepichev slepichev commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Bug Fixes
    • Added a configuration check requiring CUDA Toolkit 12.6 or newer when building cuNLS.
    • Builds now fail early with a clear error when an unsupported CUDA version is detected.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 47ed6dd9-9d53-4369-afc9-699094a76bb8

📥 Commits

Reviewing files that changed from the base of the PR and between 57f42cc and 21b0044.

📒 Files selected for processing (1)
  • cmake/ext/cunls.cmake

📝 Walkthrough

Walkthrough

cuNLS configuration now requires CUDA Toolkit 12.6 or newer and emits a fatal configuration error for older versions.

Changes

cuNLS CUDA compatibility

Layer / File(s) Summary
Enforce minimum CUDA version
cmake/ext/cunls.cmake
Adds a configuration-time CUDAToolkit_VERSION check that requires CUDA 12.6 or newer, while preserving the existing USE_CUDA guard and cuNLS setup flow.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: hrabeti-nvidia, vikuznetsov-nvidia

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding a CUDA version check for cuNLS/USE_CUNLS.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch slepichev/cunls-cuda-version-check

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Test Results

Status Platform Language Total Passed Failed Errors Skipped
Orin C++ 16 16 0 0 0
Orin Python 71 70 0 0 1
Thor C++ 16 16 0 0 0
Thor Python 71 70 0 0 1
x86_64 C++ 16 16 0 0 0
x86_64 Python 71 70 0 0 1

cuVSLAM Evaluation KPIs

Config Dataset ATE,% ARE,º/m Kabsch, Losts, diff ATE,% diff ARE,º/m diff Kabsch, diff Losts, FPS,Hz
x86_64-cuda12.6.3-ubuntu24.04 KITTI-STEREO_ODOM 0.8439 0.0023 2.8522 0 NA NA NA NA 307.9
x86_64-cuda12.6.3-ubuntu24.04 KITTI-STEREO_SLAM 0.755 0.002 1.9398 0 NA NA NA NA 179.2

Artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants