[infra] Document PyCuVSLAM install for cuvslam_app - #73
Open
slepichev wants to merge 1 commit into
Open
Conversation
tools/cuvslam_app/README.md told users to run ./create_env.sh and nothing else, but that script only creates .env and installs requirements.txt. PyCuVSLAM is not in requirements.txt, so following the README verbatim left the app failing with ModuleNotFoundError: No module named 'cuvslam'. Expand the Requirements section to cover the missing steps: activating .env in the caller's shell (create_env.sh runs in a subshell, so its own source does not persist), installing PyCuVSLAM inside the environment from either a release wheel or python/ with CUVSLAM_BUILD_DIR, and a verification command. Link to the main README for the wheel compatibility matrix and CUDA prerequisites. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
slepichev
requested review from
hrabeti-nvidia and
vikuznetsov-nvidia
as code owners
July 28, 2026 01:23
📝 WalkthroughWalkthroughThe cuVSLAM application README now provides step-by-step instructions for creating and activating an environment, installing the ChangescuVSLAM application setup
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tools/cuvslam_app/README.md`:
- Around line 7-10: Add blank lines immediately before and after every fenced
code block in the README sections referenced, including the block following
“Create the virtual environment and install the third-party dependencies,” while
preserving all commands and surrounding text.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 99b7e049-cea8-4b77-bc7b-2b8b57716344
📒 Files selected for processing (1)
tools/cuvslam_app/README.md
Test Results
cuVSLAM Evaluation KPIs
Artifacts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tools/cuvslam_app/README.md told users to run ./create_env.sh and nothing else, but that script only creates .env and installs requirements.txt. PyCuVSLAM is not in requirements.txt, so following the README verbatim left the app failing with ModuleNotFoundError: No module named 'cuvslam'.
Expand the Requirements section to cover the missing steps: activating .env in the caller's shell (create_env.sh runs in a subshell, so its own source does not persist), installing PyCuVSLAM inside the environment from either a release wheel or python/ with CUVSLAM_BUILD_DIR, and a verification command. Link to the main README for the wheel compatibility matrix and CUDA prerequisites.
Summary by CodeRabbit