Skip to content

setup: include build-essential in default packages #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wyli wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

setup: include build-essential in default packages #175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/holoscan_cli/commands/setup_cmd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,21 @@ def handle_setup(cli, args: argparse.Namespace) -> None:
sys.exit(0)

if not args.scripts:
# `build-essential` pulls in gcc/g++/make — without it, CUDA base
# images (e.g. `nvcr.io/nvidia/cuda:*-base-*`) ship with `ninja-build`
# but no compiler, so cmake fails with `No CMAKE_C_COMPILER could
# be found` the moment a downstream project tries to configure.
install_packages_if_missing(
["wget", "xvfb", "git", "unzip", "ffmpeg", "ninja-build", "libv4l-dev"],

@wyli wyli May 28, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you know what the criteria we used to decide whether a package should be included in this auto-installation command? I'm writing some tests and I couldn't remember how we came up with this list.. @tbirdso

@tbirdso tbirdso May 28, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My recollection is that this is a loose list of tools that we either directly rely on in HoloHub CLI or otherwise see commonly represented across Holoscan projects

  • General environment management: wget, git, unzip
  • holohub build tooling: cmake, ,ninja-build
  • Tools commonly used at build or runtime in Holoscan projects: xvfb, ffmpeg, libv4l-dev

[
"build-essential",
"wget",
"xvfb",
"git",
"unzip",
"ffmpeg",
"ninja-build",
"libv4l-dev",
],
dry_run=args.dryrun,
)

Expand Down
Loading