-
Notifications
You must be signed in to change notification settings - Fork 115
feat(module): add module remove command #1306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e7a7bf4
feat: add remove command
Flo0806 1294c1b
chore: tests
Flo0806 e1f383d
chore: refactor
Flo0806 1e4f033
fix: coderabbit
Flo0806 592109e
chore: add more tests
Flo0806 ede7d76
Merge branch 'main' into feat/module-remove
atinux 0566f14
Merge branch 'main' into feat/module-remove
atinux 4f3cdbb
refactor(module): align remove with add and make peer removal opt-in
danielroe 4e1983c
refactor(module): share project-deps, nuxt guard and arg helpers betw…
danielroe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid forwarding undefined/null option values in chained args.
forwardCommandArgscurrently serializes absent values into flags like--logLevel=undefined, which can leak invalid values intorunCommand(...)invocations.Suggested patch
export function forwardCommandArgs(args: Record<string, unknown>): string[] { return Object.entries(args) - .filter(([k]) => k in cwdArgs || k in logLevelArgs) - .map(([k, v]) => `--${k}=${v}`) + .filter(([k, v]) => + (Object.prototype.hasOwnProperty.call(cwdArgs, k) + || Object.prototype.hasOwnProperty.call(logLevelArgs, k)) + && v !== undefined + && v !== null, + ) + .map(([k, v]) => `--${k}=${String(v)}`) }🤖 Prompt for AI Agents