Skip to content

Call NotifyTop after pushing the table length onto the stack #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dargones wants to merge 2 commits into
base: main
Choose a base branch
from
+13 −0
Open

Call NotifyTop after pushing the table length onto the stack #331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a63f819
Call NotifyTop after pushing the length of a table onto the stack
Dargones Jul 22, 2026
d7d251c
Add a regression test to verify that the stack is cleared correctly a…
Dargones Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Lua/Runtime/LuaVirtualMachine.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2666,6 +2666,7 @@ out metamethod
{
var RA = context.Instruction.A + context.FrameBase;
stack.Get(RA) = table.ArrayLength;
stack.NotifyTop(RA + 1);
return true;
}

Expand Down
1 change: 1 addition & 0 deletions tests/Lua.Tests/LuaTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ static string PatchFilesLuaSource(string source)
[TestCase("tests-lua/coroutine.lua")]
[TestCase("tests-lua/db.lua")]
[TestCase("tests-lua/verybig.lua")]
[TestCase("tests-lua/table-length.lua")]

@akeit0 akeit0 Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although not explicitly stated, LuaTests (tests-lua) is a port of the official Lua tests; therefore, if possible, please write dedicated test in the appropriate classes.

public async Task Test_Lua(string file)
{
var path = FileHelper.GetAbsolutePath(file);
Expand Down
11 changes: 11 additions & 0 deletions tests/Lua.Tests/tests-lua/table-length.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
function f1()
local c = {}
return #c
end

function f2(a, b)
assert(b == nil)
end

f1()
f2()