Implement activity frames recorder and sessionization fixes - #46
Open
himanshuVashisthcloud wants to merge 2 commits into
Open
Implement activity frames recorder and sessionization fixes#46himanshuVashisthcloud wants to merge 2 commits into
himanshuVashisthcloud wants to merge 2 commits into
Conversation
Owner
|
thanks for the effort here - but I can't take this as one PR, and part of it I can't take at all in this shape. the windows recorder can't live inside the package: the architecture deliberately keeps capture engines out of the compiler (separate pinned binary, hash-verified, or bring your own via $AFRAMES_DB with compatible frames/ui_events/elements tables). shipping recorder code in the pip package is also a supply-chain surface I won't add. the sessionization/steps fixes might be real though - split them into their own small PR with tests and I'll review properly. and windows support IS wanted, so if you build the recorder as its own repo that writes the compatible schema, I'll happily link it from the README. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Checklist
pytest -qpasses