Make a picked photo unmistakable, and add a walk for the undecided ones - #3
Open
non7top wants to merge 1 commit into
Open
Make a picked photo unmistakable, and add a walk for the undecided ones#3non7top wants to merge 1 commit into
non7top wants to merge 1 commit into
Conversation
Whether the photo in front of you is going to be printed was being said only by the colour of a one-and-a-half-pixel outline. It is now said three ways at once: the space around the picture turns green, the shade over the part of the photo outside the crop is tinted with it -- a far larger target for the eye than any border -- and it is labelled in words, because colour alone is not something everyone can read. The one thing deliberately left untinted is the area inside the crop window that falls outside the photo. That is a preview of the actual printed border, and colouring it to mean something else would be a lie about the output. Walk gains a third mode. Having ticked the obvious keepers, "Unselected" visits only what is still undecided, so the ones already dealt with stop getting in the way. Each mode carries its count, and a mode that would visit nothing falls back to plain stepping rather than stranding you.
|
Windows build ready for Download and run it. No unpacking, no installer, no runtime needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two requests: stronger indication that a photo is picked, and a
Walkmode forthe ones not picked yet.
Seeing the decision
Whether the photo in front of you is going to be printed was being said only by
the colour of a 1.5-pixel outline. It is now said three ways at once:
larger target for the eye than any border
everyone can read
One thing is deliberately left untinted: the area inside the crop window that
falls outside the photo. That is a preview of the real printed border, and
colouring it to mean something else would be a lie about the output.
Walking the undecided ones
Walk: All / Selected / Unselected, each with its count. Unselected is thesecond pass — having ticked the obvious keepers, it visits only what is still
undecided so the ones already dealt with stop getting in the way. A mode that
would visit nothing falls back to plain stepping rather than stranding you on a
photo with no way forward.
The ini accepts
all,selectedandunselected, plus the spellings peoplereach for (
picked,remaining).150 core tests pass. The visual weight of the green — whether it is too much
over a photo, or not enough — is a judgement that wants eyes on the real thing.