Switch from ArrayPool to MemoryPool to use Span<T> - #1
Conversation
Switched the Modbus client implementation from `ArrayPool` to `MemoryPool` to leverage `Span<T>` and `Memory<T>` for better performance and reduced memory allocations. Changes: - Replaced `ArrayPool<byte>` with `MemoryPool<byte>` in `ModbusFrameBuffer`. - Introduced `SpanReader` and `SpanWriter` to work directly with spans, replacing the `Stream`-based `ExtendedBinaryReader` and `ExtendedBinaryWriter`. - Updated `ModbusClient`, `ModbusRtuClient`, and `ModbusTcpClient` to use the new span-based readers and writers. - Extended the `IModbusRtuSerialPort` interface and its implementation to support `Memory<byte>` and `ReadOnlyMemory<byte>`. - Manually updated the generated asynchronous methods to reflect the changes, as the build environment lacked the `dotnet` command to run the T4 templates automatically.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This pull request refactors the Modbus client to use
MemoryPool<byte>instead ofArrayPool<byte>, enabling the use ofSpan<T>andMemory<T>for improved performance. This addresses issue Apollo3zehn#3.PR created automatically by Jules for task 11433271621431476547 started by @nokkies