Typeset block $$…$$ math in display style, not text style - #147
Closed
manemajef wants to merge 1 commit into
Closed
Conversation
manemajef
force-pushed
the
codex/latex-render-mode
branch
from
August 12, 2026 23:32
3edbb69 to
439cc81
Compare
Author
|
Superseded by #153 — same change, rebased onto current main, with the test-target split and protocol defaults cleaned up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The parser and layout already distinguished inline and block math, but both styling paths passed only delimiter-free content through LatexRenderer. SwiftMathBridge therefore had no mode information and forced every formula into text style.
Compatibility
Existing LatexRenderer conformers can continue implementing only the original method. The new mode-aware requirement has a default implementation that forwards the same delimiter-free content to that method.
Validation