Skip to content

module: reject package map subpaths that escape the target package - #65502

Open
islandryu wants to merge 1 commit into
nodejs:mainfrom
islandryu:package-map-traversal-fix
Open

module: reject package map subpaths that escape the target package#65502
islandryu wants to merge 1 commit into
nodejs:mainfrom
islandryu:package-map-traversal-fix

Conversation

@islandryu

Copy link
Copy Markdown
Member

Fixes: #65501

Fixes: nodejs#65501

Signed-off-by: islandryu <shimaryuhei@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run. labels Aug 23, 2026
@codecov

codecov Bot commented Aug 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.14%. Comparing base (65f518c) to head (ddd6558).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65502      +/-   ##
==========================================
+ Coverage   90.12%   90.14%   +0.01%     
==========================================
  Files         751      751              
  Lines      252638   252653      +15     
  Branches    47551    47552       +1     
==========================================
+ Hits       227689   227747      +58     
+ Misses      16238    16196      -42     
+ Partials     8711     8710       -1     
Files with missing lines Coverage Δ
lib/internal/modules/package_map.js 100.00% <100.00%> (ø)

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Package map subpath resolves outside the target package directory

2 participants