Skip to content

tools: fix the list of globals in ESLint config files - #65281

Merged
aduh95 merged 2 commits into
nodejs:mainfrom
aduh95:fix-globals
Aug 23, 2026
Merged

tools: fix the list of globals in ESLint config files#65281
aduh95 merged 2 commits into
nodejs:mainfrom
aduh95:fix-globals

Conversation

@aduh95

@aduh95 aduh95 commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

As reported in #64894 (comment), we were missing some entries. I also took the liberty of reordering the list in ASCII order as there were only a few items out of order.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Aug 14, 2026
Comment thread lib/eslint.config_partial.mjs Outdated
Comment thread lib/eslint.config_partial.mjs Outdated
Comment thread lib/eslint.config_partial.mjs Outdated
@aduh95 aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Aug 14, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 16, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/65281
✔  Done loading data for nodejs/node/pull/65281
----------------------------------- PR info ------------------------------------
Title      tools: fix the list of globals in ESLint config files (#65281)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:fix-globals -> nodejs:main
Labels     tools, author ready, needs-ci, commit-queue, commit-queue-squash
Commits    2
 - tools: fix the list of globals in ESLint config files
 - squash! fix typo
Committers 2
 - Antoine du Hamel <duhamelantoine1995@gmail.com>
 - GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/65281
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65281
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 14 Aug 2026 08:52:23 GMT
   ✔  Approvals: 4
   ✔  - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/65281#pullrequestreview-4937011700
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/65281#pullrequestreview-4937868624
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/65281#pullrequestreview-4938070764
   ✔  - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/65281#pullrequestreview-4940627512
   ⚠  This PR has conflicts that must be resolved
   ✔  Last GitHub CI successful
   ✘  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/31937660121

@trivikr

trivikr commented Aug 21, 2026

Copy link
Copy Markdown
Member

This needs a rebase

@trivikr trivikr removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Aug 21, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. and removed needs-ci PRs that need a full CI run. labels Aug 23, 2026
Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
@aduh95
aduh95 merged commit 220ee76 into nodejs:main Aug 23, 2026
14 checks passed
@aduh95

aduh95 commented Aug 23, 2026

Copy link
Copy Markdown
Contributor Author

Landed in 220ee76

@aduh95
aduh95 deleted the fix-globals branch August 23, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants