test: deflake test-net-listen-ipv6only#64173
Open
Han5991 wants to merge 2 commits into
Open
Conversation
nodejs-github-bot
added
needs-ci
The test verified ipv6Only by connecting to the IPv4 side of an ephemeral port and expecting ECONNREFUSED, but it never reserved that IPv4 port. Under parallel execution another test could occupy it, making the connection succeed instead of being refused. Run the test sequentially with a fixed common.PORT so it no longer competes with other tests for the same port, matching the fix already applied to the sibling cluster variants. Fixes: nodejs#64172 Signed-off-by: sangwook <rewq5991@gmail.com>
Han5991
force-pushed
the
fix/flaky-test-net-listen-ipv6only
branch
from
29bd615 to
91860b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-net-listen-ipv6onlyconnects to the IPv4 side of an ephemeral portexpecting
ECONNREFUSED, but never reserves that port, so under parallelexecution another test can occupy it and the connection succeeds instead —
making the test flaky (it passes reliably in isolation).
Move the test to
test/sequential/and use a fixedcommon.PORTso it nolonger competes with other tests for the same port. This is the same fix
previously applied to the sibling cluster variants (#26298, #32381, #32398).
Fixes: #64172