vfs: support writeFileSync with virtual fds#64165
Open
trivikr wants to merge 2 commits into
Open
Conversation
Route fs.writeFileSync() and fs.appendFileSync() calls with VFS-owned file descriptors through the virtual file handle instead of falling back to the native fs binding. This preserves descriptor semantics for both memory-backed VFS files and RealFSProvider handles. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
nodejs-github-bot
added
needs-ci
github-actions
Bot
removed
the
request-ci
Collaborator
trivikr
added
the
author ready
jasnell
approved these changes
Jun 27, 2026
|
|
||
| function writeFileSyncFd(fd, data, options) { | ||
| const vfd = getVirtualFd(fd); | ||
| if (!vfd) return undefined; |
Member
There was a problem hiding this comment.
I know vfd's aren't going to be 0 but this seems brittle to me. Can we make this check more explicit rather than relying on a falsy coercion?
trivikr
removed
the
author ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64164
This updates VFS fs dispatch so
fs.writeFileSync(fd, data)andfs.appendFileSync(fd, data)work with VFS-owned file descriptors instead offalling through to the native fs binding and throwing
EBADF.The fd path now writes through the virtual file handle, preserving descriptor
semantics for both memory-backed VFS files and
RealFSProviderhandles.Assisted-by: openai:gpt-5.5