benchmark: fix calibrate-n option handling#64146
Open
luanmuniz wants to merge 1 commit into
Open
Conversation
Fix broken parsing for --cv-threshold and --max-increases so the value after the equals sign is used. Use the configured CV threshold when checking overall stability and report the configured thresholds in calibrate-n output. Also handle invalid numeric values for --runs and --cv-threshold consistently with the other numeric options. Signed-off-by: Luan Muniz <luan@luanmuniz.com.br>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
benchmark
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a few issues in
benchmark/calibrate-n.jsfound while using the tool to calibrate new benchmark values.Before this change,
--cv-thresholdand--max-increaseswere parsed from the wrong substring index. The parsed value still included the=separator, so values such as--cv-threshold=0.035and--max-increases=1were read as=0.035and=1. This made--cv-thresholdbecomeNaNand caused--max-increasesto fall back to the default value.This also updates the stability checks and output so the configured threshold is used consistently. Previously, parts of the tool still compared the overall CV against the default
CV_THRESHOLDand printed hardcoded5%/10%thresholds even when custom values were provided.Changes included:
--cv-threshold--max-increasescvThresholdwhen checking overall stability--runsand--cv-thresholdvalues consistently with the other numeric optionsnvalue and the per-config CV threshold--start-nhelp text to match the actual already-in-place default value