crypto: add null checks for OPENSSL_INIT_new() - #63457
Open
ndossche wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #63457 +/- ##
=======================================
Coverage 90.12% 90.13%
=======================================
Files 751 751
Lines 252536 252538 +2
Branches 47519 47524 +5
=======================================
+ Hits 227598 227618 +20
+ Misses 16250 16243 -7
+ Partials 8688 8677 -11
🚀 New features to boost your workflow:
|
Contributor
|
This pull request has been marked as stale due to 90 days of inactivity. |
tniessen
approved these changes
Aug 19, 2026
jasnell
approved these changes
Aug 20, 2026
Other calls in initialization code often already check for null pointers via CHECK_NOT_NULL(). Do the same here. Signed-off-by: ndossche <7771979+ndossche@users.noreply.github.com>
Member
|
Rebased to re-run CI, as retry option was not available on old failed CI run. @jasnell Can you please re-approve? |
jasnell
approved these changes
Aug 22, 2026
trivikr
added
request-ci
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
avivkeller
approved these changes
Aug 23, 2026
Collaborator
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Other calls in initialization code often already check for null pointers via CHECK_NOT_NULL(). Do the same here.
This was found with the help of a static-dynamic analyzer I'm working on.