Skip to content

tools: enable eslint concurrency mode - #62352

Open
JLHwung wants to merge 1 commit into
nodejs:mainfrom
JLHwung:improve-eslint-ci-perf
Open

tools: enable eslint concurrency mode#62352
JLHwung wants to merge 1 commit into
nodejs:mainfrom
JLHwung:improve-eslint-ci-perf

Conversation

@JLHwung

@JLHwung JLHwung commented Mar 20, 2026

Copy link
Copy Markdown
Contributor

In this PR we enable the ESLint --concurrency mode. Per report from TIME(1), a cache-missed eslint job has improved from 75 seconds to 25 seconds on my machine. In the cache-hit scenario, both mode exit in less than 2 seconds.

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Mar 20, 2026
@anonrig

anonrig commented Mar 20, 2026

Copy link
Copy Markdown
Member

We also bumped all eslint deps. Linter is still happy, no code changes are required.

Can you open a different pull-request for this?

@codecov

codecov Bot commented Mar 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.16%. Comparing base (f96dccc) to head (2ecbf9a).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #62352   +/-   ##
=======================================
  Coverage   90.15%   90.16%           
=======================================
  Files         751      751           
  Lines      253443   253443           
  Branches    47729    47731    +2     
=======================================
+ Hits       228496   228508   +12     
- Misses      16201    16208    +7     
+ Partials     8746     8727   -19     

see 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JLHwung

JLHwung commented Mar 20, 2026

Copy link
Copy Markdown
Contributor Author

We also bumped all eslint deps. Linter is still happy, no code changes are required.

Can you open a different pull-request for this?

Sure, open #62356.

@anonrig

anonrig commented Mar 20, 2026

Copy link
Copy Markdown
Member

Can you update this PR?

@JLHwung
JLHwung force-pushed the improve-eslint-ci-perf branch from 8255ac3 to 7831d51 Compare March 20, 2026 18:16
@JLHwung JLHwung changed the title tools: enable eslint concurrency mode and bump eslint deps tools: enable eslint concurrency mode Mar 20, 2026
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 25, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 26, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@JLHwung

JLHwung commented Apr 1, 2026

Copy link
Copy Markdown
Contributor Author

It seems that CI errors are not related, could anyone restart the CI?

@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

@github-actions github-actions Bot added the stale label Jul 28, 2026
@JLHwung

JLHwung commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

Not stale. I don't have the Jenkins CI permission so don't what is going on, could anyone restart the CI?

@github-actions github-actions Bot removed the stale label Jul 28, 2026
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@trivikr trivikr added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Aug 23, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 23, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Commit Queue failed

⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!

The pull request was removed from the Commit Queue and labeled commit-queue-failed An error occurred while landing this pull request using GitHub Actions. . After resolving the failure, remove that label and add commit-queue Add this label to land a pull request using GitHub Actions. to retry.

Full Commit Queue output
- Loading data for nodejs/node/pull/62352
✔  Done loading data for nodejs/node/pull/62352
----------------------------------- PR info ------------------------------------
Title      tools: enable eslint concurrency mode (#62352)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     JLHwung:improve-eslint-ci-perf -> nodejs:main
Labels     build, tools, author ready, needs-ci, commit-queue
Commits    1
 - tools: enable concurrency for eslint
Committers 1
 - Huáng Jùnliàng <jlhwung@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/62352
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/62352
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 20 Mar 2026 15:30:45 GMT
   ✔  Approvals: 4
   ✔  - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/62352#pullrequestreview-3988128487
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/62352#pullrequestreview-3988257998
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/62352#pullrequestreview-4009815856
   ✔  - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/62352#pullrequestreview-4010284063
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-08-23T15:35:56Z: https://ci.nodejs.org/job/node-test-pull-request/76300/
- Querying data for job/node-test-pull-request/76300/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 62352
From https://github.com/nodejs/node
 * branch                  refs/pull/62352/merge -> FETCH_HEAD
✔  Fetched commits as 82e7ff4f8452..7831d51999ce
--------------------------------------------------------------------------------
Auto-merging Makefile
[main 00fec459bd] tools: enable concurrency for eslint
 Author: Huáng Jùnliàng <jlhwung@gmail.com>
 Date: Wed Mar 18 17:59:15 2026 -0400
 1 file changed, 3 insertions(+), 2 deletions(-)
   ✔  Patches applied
--------------------------------------------------------------------------------
--------------------------------- New Message ----------------------------------
tools: enable concurrency for eslint

PR-URL: https://github.com/nodejs/node/pull/62352
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
--------------------------------------------------------------------------------
[main f2176a2fec] tools: enable concurrency for eslint
 Author: Huáng Jùnliàng <jlhwung@gmail.com>
 Date: Wed Mar 18 17:59:15 2026 -0400
 1 file changed, 3 insertions(+), 2 deletions(-)
  ✖  f2176a2fecb36e79913dd64262061e9eb7a185ef
     ✔  0:0      no Assisted-by metadata                   assisted-by-is-trailer
     ✔  0:0      no Co-authored-by metadata                co-authored-by-is-trailer
     ✔  0:0      skipping fixes-url                        fixes-url
     ✔  0:0      blank line after title                    line-after-title
     ✔  0:0      line-lengths are valid                    line-length
     ✔  0:0      metadata is at end of message             metadata-end
     ✔  1:8      PR-URL is valid.                          pr-url
     ✔  0:0      reviewers are valid                       reviewers
     ✖  0:0      Commit must have a "Signed-off-by" trailer signed-off-by
     ✔  0:0      valid subsystems                          subsystem
     ✔  0:0      Title is formatted correctly.             title-format
     ✔  0:0      Title is <= 50 columns.                   title-length
--------------------------------------------------------------------------------
   ℹ  Please fix the commit message and try again.
Please manually ammend the commit message, by running
`git commit --amend`
Once commit message is fixed, finish the landing command running
`git node land --continue`

View workflow run

@trivikr trivikr removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 23, 2026
@trivikr trivikr removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Aug 23, 2026
@trivikr

trivikr commented Aug 23, 2026

Copy link
Copy Markdown
Member

@JLHwung Can you please sign your commit message and force push?

It's required as per instructions

Your commit must contain the Signed-off-by line with your name and email address as an acknowledgement that you agree to the Developer Certificate of Origin.

Signed-off-by: Huáng Jùnliàng <jlhwung@gmail.com>
@JLHwung
JLHwung force-pushed the improve-eslint-ci-perf branch from 7831d51 to 2ecbf9a Compare August 24, 2026 01:28
@JLHwung

JLHwung commented Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

@JLHwung Can you please sign your commit message and force push?

It's required as per instructions

Your commit must contain the Signed-off-by line with your name and email address as an acknowledgement that you agree to the Developer Certificate of Origin.

Thank you. Rebased and signed off.

@trivikr trivikr added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Aug 24, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 24, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants