Verify C++ binaries run with right stdlib#604
Open
nikobockerman wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a CI/runtime guard to ensure C++ artifacts produced by the solver build actually load the intended C++ standard library at runtime (not just link against it), preventing silent fallback to system-provided libstdc++/libc++.
Changes:
- Introduces a new
misetask (cpp:verify-runtime-stdlib) that scans a CMake build directory and verifies resolved runtime library paths vialdd(Linux) /otool(macOS). - Integrates the verification into the C++ GitHub Actions workflow, selecting the expected runtime prefix based on the matrix (
libstdc++vslibc++, hardened vs non-hardened).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
mise-tasks/cpp/verify-runtime-stdlib.py |
New verifier script that inspects built binaries and asserts libstdc++/libc++ loads from an expected prefix. |
.github/workflows/cpp-build-test-run.yaml |
Adds a workflow step to run the verifier with an expected prefix derived from the build matrix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nikobockerman
force-pushed
the
verify-cpp-binaries-run-with-correct-stdlib
branch
from
7c1c91d to
f6b0a83
Compare
nikobockerman
force-pushed
the
verify-cpp-binaries-run-with-correct-stdlib
branch
from
f6b0a83 to
e091b2b
Compare
nikobockerman
force-pushed
the
verify-cpp-binaries-run-with-correct-stdlib
branch
from
e091b2b to
3c44a71
Compare
nikobockerman
force-pushed
the
verify-cpp-binaries-run-with-correct-stdlib
branch
from
3c44a71 to
d833628
Compare
nikobockerman
force-pushed
the
verify-cpp-binaries-run-with-correct-stdlib
branch
from
d833628 to
3edc7a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.