Reject window stat past lower source end - #567
Open
carrerasdarren-cell wants to merge 1 commit into
Open
Conversation
For unknown-length windows, subtracting a start beyond the lower source size wrapped the reported zip_uint64_t size. Return ZIP_ER_INVAL and cover the public API path with a regression test. Assisted-by: OpenAI Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
zip_source_stat()ZIP_UINT64_MAX(or another wrapped size)Before this change, a one-byte buffer wrapped with
zip_source_window_create(base, 2, -1, ...)reported a size of18446744073709551615. File-backed sources already reject the equivalent range withZIP_ER_INVAL; the window source now does the same when its lower source exposes a size.Verification
regress/programs/source_seek.cdirectly