Fix extra field setter return value - #566
Open
carrerasdarren-cell wants to merge 1 commit into
Open
Conversation
Map the internal boolean result to the public API's documented 0/-1 convention and cover the invalid-index error path with a regression test.\n\nAssisted-by: OpenAI Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extra-field refactor changed
zip_file_extra_field_set()from returning0directly to returning the boolean result of_zip_extra_fields_set(). This inverted the public API contract: successful calls returned1instead of0, while failures returned0instead of-1. In particular, an invalid extra-field index was reported as success.Map the internal boolean to the documented public return values and add a regression test for the invalid-index path. This behavior is on current main only, so no released version is affected.
Verification:
ctest --test-dir build-asan --output-on-failure -j4Assisted-by: OpenAI Codex