Update react-resize-detector to v12 for React 19 support - #385
Open
ManiShah7 wants to merge 2 commits into
Open
Conversation
- Updated react-resize-detector from ^7.1.2 to ^12.0.0 - Narrowed peerDependencies.react to ^18.0.0 || ^19.0.0
✅ Deploy Preview for react-datasheet-grid canceled.
|
|
Exploring this package but face the issue that it doesn't support React 19. @nick-keller sorry for the ping. |
|
@nick-keller Please review PR |
|
pls review this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
react-datasheet-grid crashes in React 19 projects due to
react-resize-detector@^7.1.2declaringreact-dom@^16/17/18as a peer dependency. When installed alongside React 19, npm resolves a nestedreact-dom@18that referencesReactSharedInternals.ReactCurrentDispatcher— which was removed in React 19 — causing a runtime error:Fixes #370, fixes #378, fixes #381
Changes
react-resize-detectorfrom^7.1.2to^12.0.0inpackage.jsonpeerDependencies.reactfrom^15 || ^16 || ^17 || ^18 || ^19to^18 || ^19to reflect the actual minimum React version required byreact-resize-detectorv12Verification
npm install— no peer dependency warningsnpm run build— TypeScript compilation succeedsnpm test— all 15 test suites pass (99/99 tests)