feat: expose container devices to templates#757
Open
JamBalaya56562 wants to merge 1 commit into
Open
Conversation
e1c6fe6 to
4b5e1bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Exposes container device passthrough (
HostConfig.Devices) to templates, reimplementing the stale PR #277 against the currentinternal/layout.Device{PathOnHost, PathInContainer, Permissions}type and aDevices []Devicefield onRuntimeContainer.getContainers, mirroring the existing Mounts loop. go-dockerclient'sDevice.CgroupPermissionsis mapped toDevice.Permissions.Use case: discovering forwarded device nodes (webcams, USB-serial adapters, etc.) from templates.
Notes
HostConfig(introduced in fix: avoid panic on nil container Config/NetworkSettings/HostConfig #748) instead of dereferencingcontainer.HostConfigdirectly, so a container inspected with a nilHostConfigcannot panic.t.Fatal→t.Fatalfchurn from the original PR is dropped.HostConfig.Deviceshas been stable in go-dockerclient since 2018, so no dependency change is required.Tests
Added
TestGetContainersDevices, which drivesgetContainersagainst a mock daemon returning a device and asserts the populatedDevices. Documented theDevicestruct and a JSON example in the README.Reimplements #277