build: move dist/ bundling to release time#245
Draft
edmundmiller wants to merge 2 commits into
Draft
Conversation
- Remove committed dist/ from master; master is now source-only - Add dispatch-driven release workflow that builds dist/, creates a release commit carrying the bundle, tags vX.Y.Z + floating v2, and publishes the GitHub Release targeting that commit - Drop the 'Check dist is up to date' CI step and stale release triggers; renovate PRs no longer fail on stale bundles Users consume @v2 / @vX.Y.Z tags; @master is not a usable action ref.
- Release workflow now force-moves both vX and vX.Y tags, matching the existing tag scheme (v3, v3.0, v3.0.1) - Replace the manual orphan-branch build instructions in CONTRIBUTING with the dispatch-driven workflow procedure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the committed
dist/bundle frommasterand moves bundling to a dispatch-driven release workflow.masterbecomes source-only;dist/is gitignoredrelease.yml(workflow_dispatch, master-only, concurrency-guarded): buildsdist/, smoke-tests the bundle, creates a release commit carryingdist/, tags immutablevX.Y.Z+ floatingv2at that commit, and publishes the GitHub Release targeting itgit diff --exit-code dist/CI step and stalerelease: publishedtriggers fromtest.yml/example.ymlMotivation
Renovate PRs touching bundled code (e.g. #228, #232, #239) perpetually fail CI on the stale-dist check, which blocks the configured branch automerge. Removing
dist/frommastereliminates that failure class entirely and gets rid of unreviewable 35k-line bundle diffs.Breaking change
@masterstops working as an action ref (no bundle on master). README already documents@v2only. Anyone pinned to@mastermust switch to@v2.Release process after this PR
v2.1.0v2, and publishes the release — one button pressTesting
example.ymljobs still build from source (npm run package) and use./, unaffectednode --check dist/index.jssmoke test before tagging