Skip to content

Update aligners (bwa, bowtie2, chromap and star)#523

Open
Kevin-Brockers wants to merge 31 commits into
nf-core:devfrom
Kevin-Brockers:update_aligner
Open

Update aligners (bwa, bowtie2, chromap and star)#523
Kevin-Brockers wants to merge 31 commits into
nf-core:devfrom
Kevin-Brockers:update_aligner

Conversation

@Kevin-Brockers

@Kevin-Brockers Kevin-Brockers commented Jul 8, 2026

Copy link
Copy Markdown

This is a bit of a bigger PR - see here: #522

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • CHANGELOG.md is updated.

@Kevin-Brockers

Copy link
Copy Markdown
Author

I'm currently fixing a few more things - e.g: when using chromap the pipeline currently fails since chromap does not add readgroups by default and picard markduplicates currently fails.

I'm on it see here: nf-core/modules#12283

Therefore the tests are currently failing

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 44328ed

+| ✅ 271 tests passed       |+
#| ❔   6 tests were ignored |#
!| ❗   8 tests had warnings |!
Details

❗ Test warnings:

  • pipeline_todos - TODO string in nextflow.config: Optionally, you can add a pipeline-specific nf-core config at https://github.com/nf-core/configs
  • pipeline_todos - TODO string in nextflow.config: Update the field with the details of the contributors to your pipeline. New with Nextflow version 24.10.0
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in CONTRIBUTING.md: Add any pipeline specific contribution guidelines here, such as coding styles, procedures, checklists etc.
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes

❔ Tests ignored:

  • nextflow_config - Config default ignored: params.bamtools_filter_pe_config
  • nextflow_config - Config default ignored: params.bamtools_filter_se_config
  • files_unchanged - File ignored due to lint config: assets/nf-core-chipseq_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-chipseq_logo_dark.png
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore
  • merge_markers - Ignoring file /home/runner/work/chipseq/chipseq/modules/nf-core/bowtie2/align/tests/main.nf.test.snap

✅ Tests passed:

Run details

  • nf-core/tools version 4.0.2
  • Run at 2026-07-08 22:25:23

@Kevin-Brockers Kevin-Brockers changed the title Update aligner (bwa, bowtie2 and chromap) Update aligners (bwa, bowtie2 and chromap) Jul 8, 2026
@Kevin-Brockers Kevin-Brockers changed the title Update aligners (bwa, bowtie2 and chromap) Update aligners (bwa, bowtie2, chromap and star) Jul 8, 2026
@Kevin-Brockers Kevin-Brockers marked this pull request as ready for review July 8, 2026 22:52

@JoseEspinosa JoseEspinosa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small question and a suggestion for the fastq_align_chromap for the nf-core subworkflow

//
// Update read groups
//
PICARD_ADDORREPLACEREADGROUPS(CHROMAP_CHROMAP.out.bam, ch_fasta_fai)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is maybe a comment more for the subworkflows that does not belong here, but this will be always run regardless of whether add_readgroups is set to false

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although, in this pipeline does not have any relevance as it is always true, to be fair

Comment thread .nf-core.yml
- config_defaults:
- params.bamtools_filter_se_config
- params.bamtools_filter_pe_config
merge_markers:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this is needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update the aligners (bowtie2, bwa, chromap and star) and associated steps processing steps to use topics channel for software versions.

2 participants