Update aligners (bwa, bowtie2, chromap and star)#523
Conversation
…ch_fasta_fai dummy maps to match updated nf-core maintained samtools components
|
I'm currently fixing a few more things - e.g: when using chromap the pipeline currently fails since chromap does not add readgroups by default and picard markduplicates currently fails. I'm on it see here: nf-core/modules#12283 Therefore the tests are currently failing |
|
JoseEspinosa
left a comment
There was a problem hiding this comment.
Just a small question and a suggestion for the fastq_align_chromap for the nf-core subworkflow
| // | ||
| // Update read groups | ||
| // | ||
| PICARD_ADDORREPLACEREADGROUPS(CHROMAP_CHROMAP.out.bam, ch_fasta_fai) |
There was a problem hiding this comment.
This is maybe a comment more for the subworkflows that does not belong here, but this will be always run regardless of whether add_readgroups is set to false
There was a problem hiding this comment.
Although, in this pipeline does not have any relevance as it is always true, to be fair
| - config_defaults: | ||
| - params.bamtools_filter_se_config | ||
| - params.bamtools_filter_pe_config | ||
| merge_markers: |
This is a bit of a bigger PR - see here: #522
PR checklist
nf-core lint).nextflow run . -profile test,docker --outdir <OUTDIR>).CHANGELOG.mdis updated.