Skip to content

fix: resume interrupted complex page generations#4533

Open
nettee wants to merge 7 commits into
mainfrom
looper/4137-bug-the-generated-content-is-2789dee3c99ccd9a
Open

fix: resume interrupted complex page generations#4533
nettee wants to merge 7 commits into
mainfrom
looper/4137-bug-the-generated-content-is-2789dee3c99ccd9a

Conversation

@nettee

@nettee nettee commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • treat visible streamed output as a resumable boundary so interrupted text-heavy generations can continue instead of restarting from scratch
  • seed a new project conversation from the active conversation when its messages are loaded so project-level design context carries into the next session
  • add focused daemon and web tests that cover both behaviors

Validation

  • pnpm --filter @open-design/web test -- ProjectView.run-isolation.test.tsx
  • pnpm --filter @open-design/daemon exec vitest run -c vitest.config.ts tests/run-lifecycle-analytics.test.ts
  • pnpm guard
  • pnpm typecheck

Closes #4137

🔁 Powered by Looper · runner=worker · agent=codex · An autonomous AI dev team for your GitHub repos.

Generated-By: looper 0.9.10 (runner=worker, agent=codex)
@lefarcen lefarcen requested a review from PerishCode June 18, 2026 14:02
@lefarcen lefarcen added size/S PR changes 20-100 lines risk/high High risk: apps/desktop, daemon, auth, migration, workflows, package deps type/bugfix Bug fix needs-validation Runtime change detected; needs human or /explore agent validation. labels Jun 18, 2026
@lefarcen

Copy link
Copy Markdown
Contributor

@nettee The summary/validation details here are already clear, but could you add the Surface area checklist to the PR body and tick the boxes this change affects? That makes it easier for the next reviewer to see at a glance that this touches the conversation/resume flow.

Also, I’ve marked this with needs-validation because the ProjectView conversation behavior changed — please hold off on merging it yourself for now, and we’ll loop in QA once it’s merge-ready.

@PerishCode PerishCode left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nettee I reviewed the changed daemon resume-boundary logic and the ProjectView seeded-conversation path against the existing conversation API contract and tests. The change stays within the current web/daemon seams, keeps seeded conversation creation on the shared endpoint, and the added coverage targets the two behaviors in this bugfix. I could not rerun the focused Vitest commands locally because this prepared worktree has no installed node_modules, but the implementation reads clean for the changed ranges. Nice work keeping the fix tight and covered.

🔁 Powered by Looper · runner=reviewer · agent=codex · An autonomous AI dev team for your GitHub repos.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: decf9d740d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/web/src/components/ProjectView.tsx Outdated
Generated-By: looper 0.9.10 (runner=fixer, agent=codex)
@lefarcen

Copy link
Copy Markdown
Contributor

@nettee One small PR-body follow-up before this moves along: could you add the Surface area checklist and a brief Bug fix verification note? The summary already explains the change well — what’s still missing is a quick reviewer-facing pointer to which surface this touches, plus the specific before/after seam that proves the interrupted-generation and seeded-conversation regressions are covered.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e728bfc898

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/web/src/components/ProjectView.tsx Outdated
Generated-By: looper 0.9.10 (runner=fixer, agent=codex)
@nettee

nettee commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

Looper fixer round complete9518057

  • ✅ Review comment on apps/web/src/components/ProjectView.tsx:5078 (@chatgpt-codex-connector) — thread
    • I updated handleNewConversation in apps/web/src/components/ProjectView.tsx to depend on the full messages snapshot instead of only messages.length, and added a regression test in apps/web/tests/components/ProjectView.run-isolation.test.tsx that covers same-length message content updates before creating a new conversation.

🔁 Powered by Looper · runner=fixer · agent=codex · An autonomous AI dev team for your GitHub repos.

@chatgpt-codex-connector

Copy link
Copy Markdown

To use Codex here, create an environment for this repo.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9518057070

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/daemon/src/server.ts
Generated-By: looper 0.9.10 (runner=fixer, agent=codex)
@nettee

nettee commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

Looper fixer round completead324cd

  • ✅ Review comment on apps/daemon/src/server.ts:2191 (@chatgpt-codex-connector) — thread
    • Updated apps/daemon/tests/run-resume-on-failure.test.ts so the text-only upstream-drop case now expects a resumable failure and verifies the next turn resumes the saved session. The fake Claude fixture in that test now emits streamed text on the interrupted attempt and records CLI args for the resumed turn.

🔁 Powered by Looper · runner=fixer · agent=codex · An autonomous AI dev team for your GitHub repos.

@chatgpt-codex-connector

Copy link
Copy Markdown

To use Codex here, create an environment for this repo.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ad324cdd7a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/web/src/components/ProjectView.tsx Outdated
Generated-By: looper 0.9.10 (runner=fixer, agent=codex)
@nettee

nettee commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

Looper fixer round complete9828d70

  • ✅ Review comment on apps/web/src/components/ProjectView.tsx (@chatgpt-codex-connector) — thread
    • Updated apps/web/src/components/ProjectView.tsx so handleNewConversation sends only seedFromConversationId, and adjusted apps/web/tests/components/ProjectView.run-isolation.test.tsx to assert the compact payload instead of the full message snapshot.

🔁 Powered by Looper · runner=fixer · agent=codex · An autonomous AI dev team for your GitHub repos.

@chatgpt-codex-connector

Copy link
Copy Markdown

To use Codex here, create an environment for this repo.

Generated-By: looper 0.9.10 (runner=fixer, agent=codex)

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 40d43ebfc1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/web/src/components/ProjectView.tsx Outdated
Generated-By: looper 0.9.10 (runner=fixer, agent=codex)
@nettee

nettee commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

Looper fixer round complete8fe6ed9

  • ✅ Review comment on apps/web/src/components/ProjectView.tsx (@chatgpt-codex-connector) — thread
    • Removed seedMessages from handleNewConversation in apps/web/src/components/ProjectView.tsx so New only posts seedFromConversationId, and updated apps/web/tests/components/ProjectView.run-isolation.test.tsx to assert the compact payload.

🔁 Powered by Looper · runner=fixer · agent=codex · An autonomous AI dev team for your GitHub repos.

@chatgpt-codex-connector

Copy link
Copy Markdown

To use Codex here, create an environment for this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-validation Runtime change detected; needs human or /explore agent validation. risk/high High risk: apps/desktop, daemon, auth, migration, workflows, package deps size/S PR changes 20-100 lines type/bugfix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: The generated content is always incomplete when doing some complex pages.

3 participants