[codex] Keep prefetched brand pages previewable#4530
Conversation
|
Hey @PerishCode — quick heads-up that #4532 is also open from you against the same brand-extraction follow-up, and the changed-file set is currently identical across both PRs ( If these are meant to land together, consolidating into one PR will make review and merge much simpler. |
nettee
left a comment
There was a problem hiding this comment.
Found one blocking regression in the new brand-status reconcile path: it now treats any later canceled/failed run on the backing project as an extraction failure, so already-ready brands can be flipped back to failed after unrelated follow-up work.
|
Hey @PerishCode — the current blocker to address is @nettee's review on this head: the new reconcile path is reading the latest project-wide run status, so a later canceled/failed follow-up run can flip an already-ready brand back to Once that persisted failure reconcile is scoped back to active extraction only — or tied to the specific extraction run instead of the latest project run — this should be in good shape for another pass. 💡 To drive this PR to merge hands-free, paste this to your AI coding agent (Claude Code / Codex / opencode / Cursor …): |
Generated-By: looper 0.9.10+codex.autoclean (runner=fixer, agent=codex)
|
Looper fixer round complete — ab3cccd
🔁 Powered by Looper · runner=fixer · agent=codex · An autonomous AI dev team for your GitHub repos. |
nettee
left a comment
There was a problem hiding this comment.
Found one remaining blocking hole in the status-reconcile change: the new guard protects ready brands, but active extractions are still matched against the latest project-wide run rather than the extraction run that owns the brand.
🔁 Powered by Looper · runner=reviewer · agent=codex · An autonomous AI dev team for your GitHub repos.|
Hey @PerishCode — the current blocker on this head is covered by @nettee's latest review: the ready-brand regression is fixed, but active extraction is still being reconciled against the latest project-wide run instead of the extraction run that owns the brand. Once that reconcile path is tied to the extraction-owned run (or otherwise scoped so later unrelated project runs cannot drive extraction status), this should be ready for another pass. |
Generated-By: looper 0.9.10+codex.autoclean (runner=fixer, agent=codex)
|
Looper fixer round complete — 55d8562
🔁 Powered by Looper · runner=fixer · agent=codex · An autonomous AI dev team for your GitHub repos. |
Generated-By: looper 0.9.10+codex.autoclean (runner=fixer, agent=codex)
|
Hey @PerishCode — the latest blocker on this head is the correctness issue @nettee called out in the conversation-scoped status lookup: Also, this PR now has user-visible refresh/status behavior changes, so I've marked it |
Generated-By: looper 0.9.10+codex.autoclean (runner=fixer, agent=codex)
|
Looper fixer round complete — 5c9e955
🔁 Powered by Looper · runner=fixer · agent=codex · An autonomous AI dev team for your GitHub repos. |
nettee
left a comment
There was a problem hiding this comment.
@PerishCode I reviewed the changed daemon reconcile path, the conversation-scoped status lookup, the prefetch preview fallback, and the focused regression coverage added on this head. The remaining ordering concern from the prior thread is addressed by the new conversation-position tie-breaker, and I did not find any further actionable issues in the changed ranges.
Nice cleanup on the follow-up fixes here.
🔁 Powered by Looper · runner=reviewer · agent=codex · An autonomous AI dev team for your GitHub repos.
Why
This PR keeps prefetched brand pages previewable on top of #4260.
The pain being addressed is brand extraction reliability: terminal status reconciliation and prefetch persistence need to preserve enough page material for preview/debug flows instead of losing the page once extraction settles.
What users will see
In the #4260 Brand Kit flow, prefetched brand pages remain available for preview while terminal extraction statuses reconcile more consistently.
Surface area
apps/weborapps/desktop(including Electron menu bar)odsubcommand or flag, newtools-dev/tools-pack/tools-prflag, or newOD_*env varskills/,design-systems/,design-templates, orcraft/, or change to the skills protocolTRANSLATIONS.mdfor the locale workflow)package.json(dependenciesordevDependencies); workspace-packagepackage.jsonfiles are out of scope.Screenshots
Not applicable.
Bug fix verification
Skipped. The branch includes focused daemon brand prefetch/routes tests, but I did not rerun them locally while opening this PR.
Validation