Skip to content

[codex] Fix Brand Kit modal intent handling#4528

Open
PerishCode wants to merge 1 commit into
even-ferryfrom
codex/fix-brand-kit-modal-intent
Open

[codex] Fix Brand Kit modal intent handling#4528
PerishCode wants to merge 1 commit into
even-ferryfrom
codex/fix-brand-kit-modal-intent

Conversation

@PerishCode

Copy link
Copy Markdown
Contributor

Why

This PR fixes Brand Kit modal intent handling on top of #4260.

The pain being addressed is interaction correctness: modal-triggered Brand Kit intents should route through the Brands tab consistently instead of being dropped or handled at the wrong time.

What users will see

In the #4260 Brand Kit flow, modal intent handling should be more reliable when opening or refreshing the Brands tab path.

Surface area

  • UI — Brand Kit modal intent handling in apps/web
  • Keyboard shortcut — new or changed
  • CLI / env var — new od subcommand or flag, new tools-dev / tools-pack / tools-pr flag, or new OD_* env var
  • API / contract — new /api/* endpoint, new SSE event, or changed shape in packages/contracts
  • Extension point — new entry under skills/, design-systems/, design-templates, or craft/, or change to the skills protocol
  • i18n keys — added new translation keys (see TRANSLATIONS.md for the locale workflow)
  • New top-level dependency — adding any new entry to the root package.json (dependencies or devDependencies); workspace-package package.json files are out of scope.
  • Default behavior change — Brand Kit modal intent behavior changes in the Agent-driven brand extraction + two-loop memory overhaul #4260 flow
  • None — internal refactor, docs, tests, or translation update only

Screenshots

Not attached. Intent handling is covered by the branch test changes.

Bug fix verification

Skipped. The branch includes focused component test coverage, but I did not rerun it locally while opening this PR.

Validation

  • Not run locally; PR opened from the existing branch for review.

@lefarcen

Copy link
Copy Markdown
Contributor

🧪 This PR changes a user-facing interaction path, so it should go through a manual QA pass before merge — please hold off self-merging for now; we’ll loop QA in once it is merge-ready (and after any needed design/product sign-off).

@lefarcen lefarcen requested a review from mrcfps June 18, 2026 12:20
@lefarcen lefarcen added size/S PR changes 20-100 lines risk/medium Medium risk: regular code changes type/bugfix Bug fix needs-validation Runtime change detected; needs human or /explore agent validation. labels Jun 18, 2026

@mrcfps mrcfps left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PerishCode I reviewed the changed BrandsTab intent gating and the added regression coverage around hidden-view intent queuing and re-entry modal behavior. The updated flow now holds the one-shot Brand Kit intent until the Brands view is active again and avoids reopening it after leaving the Brands tab. Thanks for tightening this interaction path and adding focused tests here ✨

🔁 Powered by Looper · runner=reviewer · agent=opencode · An autonomous AI dev team for your GitHub repos.

@lefarcen lefarcen requested a review from AmyShang-alt June 18, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-validation Runtime change detected; needs human or /explore agent validation. risk/medium Medium risk: regular code changes size/S PR changes 20-100 lines type/bugfix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants