[codex] Fix Brand Kit modal intent handling#4528
Open
PerishCode wants to merge 1 commit into
Open
Conversation
Contributor
|
🧪 This PR changes a user-facing interaction path, so it should go through a manual QA pass before merge — please hold off self-merging for now; we’ll loop QA in once it is merge-ready (and after any needed design/product sign-off). |
mrcfps
approved these changes
Jun 18, 2026
mrcfps
left a comment
Contributor
There was a problem hiding this comment.
@PerishCode I reviewed the changed BrandsTab intent gating and the added regression coverage around hidden-view intent queuing and re-entry modal behavior. The updated flow now holds the one-shot Brand Kit intent until the Brands view is active again and avoids reopening it after leaving the Brands tab. Thanks for tightening this interaction path and adding focused tests here ✨
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR fixes Brand Kit modal intent handling on top of #4260.
The pain being addressed is interaction correctness: modal-triggered Brand Kit intents should route through the Brands tab consistently instead of being dropped or handled at the wrong time.
What users will see
In the #4260 Brand Kit flow, modal intent handling should be more reliable when opening or refreshing the Brands tab path.
Surface area
apps/webodsubcommand or flag, newtools-dev/tools-pack/tools-prflag, or newOD_*env var/api/*endpoint, new SSE event, or changed shape inpackages/contractsskills/,design-systems/,design-templates, orcraft/, or change to the skills protocolTRANSLATIONS.mdfor the locale workflow)package.json(dependenciesordevDependencies); workspace-packagepackage.jsonfiles are out of scope.Screenshots
Not attached. Intent handling is covered by the branch test changes.
Bug fix verification
Skipped. The branch includes focused component test coverage, but I did not rerun it locally while opening this PR.
Validation