[codex] Fix Brand Kit preview lifecycle guards#4527
Conversation
|
🧪 This PR has changes that need a manual QA pass before merge — please hold off self-merging for now; we'll loop QA in once it's merge-ready (and design/product have signed off, where applicable). |
mrcfps
left a comment
There was a problem hiding this comment.
@PerishCode Thanks for tightening the Brand Kit preview lifecycle guards. I found one merge-safe follow-up in the delete path; the concrete detail is inline.
🔁 Powered by Looper · runner=reviewer · agent=opencode · An autonomous AI dev team for your GitHub repos.Generated-By: looper 0.9.10+codex.autoclean (runner=fixer, agent=codex)
|
Looper fixer round complete — ad1f3c0
🔁 Powered by Looper · runner=fixer · agent=codex · An autonomous AI dev team for your GitHub repos. |
mrcfps
left a comment
There was a problem hiding this comment.
@PerishCode Thanks for following up on the preview lifecycle guard work. I found one merge-safe follow-up in the delete failure path; the concrete detail is inline.
🔁 Powered by Looper · runner=reviewer · agent=opencode · An autonomous AI dev team for your GitHub repos.Generated-By: looper 0.9.10+codex.autoclean (runner=fixer, agent=codex)
|
Looper fixer round complete — f9ce970
🔁 Powered by Looper · runner=fixer · agent=codex · An autonomous AI dev team for your GitHub repos. |
mrcfps
left a comment
There was a problem hiding this comment.
@PerishCode I reviewed the updated Brand Kit preview lifecycle changes in BrandPreviewCard/BrandsTab, including the stale-route guard, delete failure handling, iframe remount keys, and the focused regression coverage added for refresh and delete paths. I did not find any actionable correctness or maintainability issues in the changed ranges. Thanks for tightening this flow and backfilling the follow-up tests.
Why
This PR fixes brand kit preview lifecycle guards on top of #4260.
The pain being addressed is state reliability: preview cards and the Brands tab need to avoid stale or unsafe lifecycle transitions while brand extraction and refresh state changes are in flight.
What users will see
In the #4260 Brand Kit flow, preview cards and the Brands tab should behave more consistently as extraction and refresh lifecycle state changes.
Surface area
apps/webodsubcommand or flag, newtools-dev/tools-pack/tools-prflag, or newOD_*env var/api/*endpoint, new SSE event, or changed shape inpackages/contractsskills/,design-systems/,design-templates, orcraft/, or change to the skills protocolTRANSLATIONS.mdfor the locale workflow)package.json(dependenciesordevDependencies); workspace-packagepackage.jsonfiles are out of scope.Screenshots
Not attached. Lifecycle behavior is covered by focused component tests.
Bug fix verification
Skipped. The branch includes focused component test coverage, but I did not rerun it locally while opening this PR.
Validation