[codex] Fix design-system review TOC overlay#4526
Conversation
|
🧪 This PR has changes that need a manual QA pass before merge — please hold off self-merging for now; we'll loop QA in once it's merge-ready (and design/product have signed off, where applicable). |
nettee
left a comment
There was a problem hiding this comment.
@PerishCode I reviewed the narrow-layout TOC fix in apps/web/src/styles/design-system-flow.css and the matching coverage in apps/web/tests/styles/design-system-review-density.test.ts. The container-scoped override now drops the sticky TOC behavior in the single-column review layout while preserving the wide-layout rail assertions, and the targeted test additions line up with that change. I couldn't run the focused Vitest file in this reviewer worktree because node_modules are absent here, but the patch itself looks consistent and low-risk. Nice tight fix.
Why
This PR fixes the narrow design-system review layout on top of #4260.
The pain being addressed is review usability: dense design-system contents need to remain scrollable in constrained layouts instead of being obscured by the table-of-contents overlay.
What users will see
In the #4260 design-system review flow, narrow layouts allow the contents area to scroll correctly instead of being blocked by the TOC overlay.
Surface area
apps/webodsubcommand or flag, newtools-dev/tools-pack/tools-prflag, or newOD_*env var/api/*endpoint, new SSE event, or changed shape inpackages/contractsskills/,design-systems/,design-templates, orcraft/, or change to the skills protocolTRANSLATIONS.mdfor the locale workflow)package.json(dependenciesordevDependencies); workspace-packagepackage.jsonfiles are out of scope.Screenshots
Not attached. Layout behavior is covered by the branch test.
Bug fix verification
Skipped. The branch includes focused layout test coverage, but I did not rerun it locally while opening this PR.
Validation