fix(i18n): use parameterized string for CPU name and thread count#1032
Draft
Copilot wants to merge 2 commits into
Draft
fix(i18n): use parameterized string for CPU name and thread count#1032Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
…able string The CPU row in settings-admin.php previously used a standalone translated "threads" word with the count concatenated outside the string, which doesn't work properly for RTL languages or languages with different word order. Now uses a single translatable string '%1$s (%2$d threads)' with the CPU name as %1$s and thread count as %2$d, allowing translators to reorder components as needed. Removes the old standalone "threads" key from all l10n files.
Copilot
AI
changed the title
[WIP] Add parameters like thread count as variable for i18n
fix(i18n): use parameterized string for CPU name and thread count
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CPU info cell in
settings-admin.phpconcatenated the thread count and translated word "threads" as separate fragments, breaking word ordering for RTL languages and violating Nextcloud i18n guidelines.Changes
templates/settings-admin.php: Replace fragmented output with a single parameterized translatable string:This also removes a stray
</strong>with no matching opening tag.l10n/*.jsonandl10n/*.js(60 files): Remove the now-unused standalone"threads"translation key. The new"%1$s (%2$d threads)"string will be routed through Transifex for re-translation.