Skip to content

refactor(commands): add type hinting to execute method #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CarlSchwan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor(commands): add type hinting to execute method #970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/Command/CollectionDelete.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ protected function configure() {
*
* @return int
*/
protected function execute(InputInterface $input, OutputInterface $output) {
protected function execute(InputInterface $input, OutputInterface $output): int {
$collection = $input->getArgument('name');
if (!$this->collectionService->hasCollection($collection)) {
throw new CollectionArgumentException('unknown collection');
Expand Down
2 changes: 1 addition & 1 deletion lib/Command/CollectionList.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ protected function configure() {
*
* @return int
*/
protected function execute(InputInterface $input, OutputInterface $output) {
protected function execute(InputInterface $input, OutputInterface $output): int {
$collections = $this->collectionService->getCollections();
$output->writeln('found ' . sizeof($collections) . ' collection(s)');

Expand Down
2 changes: 1 addition & 1 deletion lib/Command/DocumentPlatform.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ protected function configure() {
*
* @throws Exception
*/
protected function execute(InputInterface $input, OutputInterface $output) {
protected function execute(InputInterface $input, OutputInterface $output): int {
$providerId = $input->getArgument('providerId');
$documentId = $input->getArgument('documentId');

Expand Down
2 changes: 1 addition & 1 deletion lib/Command/DocumentProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ protected function configure() {
*
* @throws Exception
*/
protected function execute(InputInterface $input, OutputInterface $output) {
protected function execute(InputInterface $input, OutputInterface $output): int {
$providerId = $input->getArgument('providerId');
$documentId = $input->getArgument('documentId');
$userId = $input->getArgument('userId');
Expand Down
2 changes: 1 addition & 1 deletion lib/Command/DocumentStatus.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ protected function configure() {
*
* @throws Exception
*/
protected function execute(InputInterface $input, OutputInterface $output) {
protected function execute(InputInterface $input, OutputInterface $output): int {
$providerId = $input->getArgument('provider');
$documentId = $input->getArgument('document');
$value = $input->getOption('value');
Expand Down
2 changes: 1 addition & 1 deletion lib/Command/Live.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@
* @return int|null|void
* @throws Exception
*/
protected function execute(InputInterface $input, OutputInterface $output) {
protected function execute(InputInterface $input, OutputInterface $output): int {

Check failure on line 135 in lib/Command/Live.php

View workflow job for this annotation

GitHub Actions / static-phpstan-analysis 

PHPDoc tag `@return` with type int|void|null is not subtype of native type int.
if (!$input->getOption('service') && !$input->getOption('no-readline')) {
try {
/** do not get stuck while waiting interactive input */
Expand Down
2 changes: 1 addition & 1 deletion lib/Command/Search.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ protected function configure() {
* @return int
* @throws Exception
*/
protected function execute(InputInterface $input, OutputInterface $output) {
protected function execute(InputInterface $input, OutputInterface $output): int {
$searchRequest = new SearchRequest();
$searchRequest->importFromArray(
[
Expand Down
2 changes: 1 addition & 1 deletion lib/Command/Stop.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ protected function configure() {
*
* @return int
*/
protected function execute(InputInterface $input, OutputInterface $output) {
protected function execute(InputInterface $input, OutputInterface $output): int {
$output->writeln('stopping all running indexes');

$this->runningService->forceStop();
Expand Down
Loading