feat(calendar): plural default calendar reminders#8567
Conversation
291bbf9 to
69d675d
Compare
Add multi-alarm list editors in Edit Calendar settings for part-day and full-day default reminders, mirroring the event alarm editor pattern. Reads and writes plural CalDAV properties via update to cdav-library. - NC34: legacy single-dropdown UI unchanged - NC35+: DefaultAlarmsList with relative triggers and DISPLAY/EMAIL Assisted-by: Grok:grok-4 Signed-off-by: Richard Freeman <rich@rich0.org>
69d675d to
2c5ec60
Compare
Screenshot of new UI for default reminders attached.
|
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
1 participant
This PR is hand-written (other than the commit comment below, which was edited by me), but the code changes were created by AI.
I am a novice at PHP and new to Nextcloud development so I invite scrutiny. I noted questions about nextcloud dev conventions below. Everything was reviewed and tested by me with both the stable server and the new app+lib, plus the stable app and the new server.
The intent of this feature is to extend the recent default calendar reminder feature by allowing multiple reminders to be set as well as the notification type for each. Only relative reminder intervals are supported as I didn't think absolute reminders made much sense in a template. This requires changes in server, cdav-library, and the calendar app.
The server revisions are backwards-compatible with the current stable app, and the app revisions are backwards-compatible with the current stable server. In the app the UI reflects a pre-v34 server, v34 (existing defaults functionality) and v35+ (new functionality). I'll describe server-side compatibility in the server PR.
The calendar app has a dependency on the updated cdav-library, which is not reflected in package.json as I'm not sure what the convention is for bumping these revisions in tandem.
This is related to:
nextcloud/cdav-library#1066
nextcloud/server#61832
Commit comment:
Add multi-alarm list editors in Edit Calendar settings for part-day and full-day default reminders, mirroring the event alarm editor pattern. Reads and writes plural CalDAV properties via update to cdav-library.
Assisted-by: Grok:grok-4
🤖 AI (if applicable)