Skip to content

fix: string array keys are converted to int when a number #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lukasdotcom wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: string array keys are converted to int when a number #442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/Service/ApprovalService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,13 +123,17 @@ public function getUserRules(string $userId, string $role = 'requesters', ?int $
}
// get display names
foreach ($userNames as $k => $v) {
// Cast keys to string: PHP coerces numeric string array keys to int
$k = (string)$k;
$user = $this->userManager->get($k);
$userNames[$k] = $user ? $user->getDisplayName() : $k;
}
if ($circlesEnabled) {
$circlesManager = \OC::$server->get(\OCA\Circles\CirclesManager::class);
$circlesManager->startSuperSession();
foreach ($circleNames as $k => $v) {
// Cast keys to string: PHP coerces numeric string array keys to int
$k = (string)$k;
try {
$circle = $circlesManager->getCircle($k);
$circleNames[$k] = $circle->getDisplayName();
Expand Down Expand Up @@ -853,7 +857,6 @@ public function propFind(int $nodeId): int {
return $state['state'];
}


/**
* Get approval state for multiple files and loads all the tags at once
*
Expand Down
Loading