fix: use phpseclib3 namespace for X509 after server phpseclib upgrade

[oleksandr-nc]

Nextcloud server master upgraded phpseclib from v2 to v3 (nextcloud/server#48183), so the class is now phpseclib3\File\X509. This breaks every appstore-sourced ExApp install/update on NC35 with Class "phpseclib\File\X509" not found.

The X509 methods used here are unchanged between v2 and v3, so this is only the namespace rename, same as server did in lib/private/Installer.php. Main only, stable branches still ship phpseclib v2.

Fixes #978

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 939ce995-f7ab-4414-968f-54f3c10af207

📥 Commits

Reviewing files that changed from the base of the PR and between ed5c44b and 2d845fd.

📒 Files selected for processing (1)

• lib/Fetcher/ExAppArchiveFetcher.php

Included review availability: Your plan includes up to 2 reviews per rolling hour; 1 remains after this review.

---

📝 Walkthrough

Walkthrough

The archive fetcher updates its X509 class import from phpseclib\File\X509 to phpseclib3\File\X509.

Merge Risk: ⚪ Minimal · up to 2d845

This localized namespace update restores ExApp install and update compatibility with the upgraded server dependency; no actionable merge-blocking risk remains beyond completing the normal PHP checks.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the phpseclib3 namespace fix, which is the main change.
Description check	✅ Passed	The description explains the phpseclib upgrade, the resulting error, the namespace fix, and the affected branch.
Linked Issues check	✅ Passed	The change updates X509 to the phpseclib3 namespace and addresses issue #978's reported class-not-found error.
Out of Scope Changes check	✅ Passed	The pull request contains only the namespace update required to resolve the linked issue.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}