Fix DiscrimTwoSample output dependency on input order - #443
Open
ChickenisLegit wants to merge 3 commits into
Open
Fix DiscrimTwoSample output dependency on input order#443ChickenisLegit wants to merge 3 commits into
ChickenisLegit wants to merge 3 commits into
Conversation
added 2 commits
August 8, 2026 13:57
Resolves neurodata#409. Scipy multiscale_graphcorr crashes with IndexError when input has 0 variance (e.g., from block permutation of identical blocks). Caught IndexError to return 0 statistic. Also caught ValueError in compute_scale_at_lag.
✅ Deploy Preview for hyppo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
|
once CI's pass I'll merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue (#422) where DiscrimTwoSample output depended on the input order when
emove_isolates=True\ due to modifying the labels array in a loop.