Update submodules (to bring in latest functional fixes), plus a few tests fixes. - #1023
Open
ctalledo wants to merge 9 commits into
Open
Update submodules (to bring in latest functional fixes), plus a few tests fixes.#1023ctalledo wants to merge 9 commits into
ctalledo wants to merge 9 commits into
Conversation
Signed-off-by: Cesar Talledo <cesar.talledo@docker.com>
authorized_keys was world-writable, causing sshd StrictModes to reject the key with "Permission denied". Signed-off-by: Cesar Talledo <cesar.talledo@docker.com>
"chown other" asserted mkdir produces "drwxr-xr-x", but that depends on the container's umask, which isn't what the test is verifying. Capture the actual perm bits after mkdir and assert chown leaves them unchanged, regardless of what the ambient umask happens to produce. Signed-off-by: Cesar Talledo <cesar.talledo@docker.com>
"docker cp" into the test container intermittently fails with "openat etc/resolv.conf: directory not empty", reproducing regardless of whether it runs before or after apt-get install, and even when copying to "/" instead of "/usr/bin". This looks like a kernel/VFS interaction between containerd's tar-based archive extraction and the idmapped mount sysbox sets up over /etc/resolv.conf, not a test logic bug. Piping the binary in via "docker exec -i ... cat >" avoids that code path entirely and was verified stable across repeated runs. Signed-off-by: Cesar Talledo <cesar.talledo@docker.com>
"apk add bind-tools" inside a nested container, fetched via a live
custom DNS server (1.0.0.1) and external package repo, intermittently
fails ("Permission denied" from apk/wget) due to transient network/DNS
blips unrelated to sysbox -- reproducing this exact command manually
right after a failure succeeds cleanly. Wrap it with the existing
retry_run helper (already used elsewhere in the suite for this same
class of flakiness) across all 10 occurrences of the pattern in this
file.
Signed-off-by: Cesar Talledo <cesar.talledo@docker.com>
Signed-off-by: Cesar Talledo <cesar.talledo@docker.com>
A transient registry pull failure (e.g. connection reset by peer) while starting the sys container left $syscont empty, causing wait_for_inner_dockerd to fail with a confusing "docker exec docker ps" error instead of the real problem. Retry the docker_run with a plain loop (retry_run can't be used here since docker_run() calls bats' run() internally). Signed-off-by: Cesar Talledo <cesar.talledo@docker.com>
Signed-off-by: Cesar Talledo <cesar.talledo@docker.com>
rodnymolina
previously approved these changes
Jul 27, 2026
Compiling fileDac.c failed with "fatal error: sys/types.h: No such file or directory". libc6-dev is only a recommended (not hard) dependency of gcc on this Ubuntu image, so it wasn't pulled in automatically. Install it explicitly. Signed-off-by: Cesar Talledo <cesar.talledo@docker.com>
rodnymolina
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.