revert: undo PR #3/#4 pending CI-only e2e-main-help regression investigation - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
e2e-main-help-exits-cleanlypasses reliably before PR refactor: split builtin printf/macros and relocate highlight module #3 and fails deterministically in every CI run after it (both x86_64-linux and aarch64-darwin), while passing 100% in two separate full local suite runs on the same commit. This points to a CI-environment-specific (resource/timing sensitive) regression in the process/job-control refactoring in PR refactor: split builtin printf/macros and relocate highlight module #3 that could not be pinned down with confidence without further investigation.git diff 3efe546 HEADis empty, confirming this exactly restores the pre-PR#3 tree.Test plan
build release binarypatchelf permission issue and occasional aarch64-darwin PTY flake — but NOTe2e-main-help-exits-cleanly)