add skills filter to the opportunity list - #936
Open
ivannissimrch wants to merge 2 commits into
Open
Conversation
…filter-opportunities-by-skills
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a skills filter to the opportunity list, following the existing activity filter pattern.
This needs a backend change first.
getOpportunityWherehas noskillbranch. So the filter renders and reaches the URL. Still, nothing is filtered until that lands.filter.skillis already declared inQuerystringOpportunityFilteringand the list route already eager-loadsdeal.dealSkill.skill, so only the where-clause is missing. No SDK change needed.I have the backend side working locally with a unit test, verified end-to-end against my own backend, but I could not open the BE PR. The pre-push hook runs the full test suite, and it does not pass on my machine:
getDateObjexpects day 11 and I get 10, and the onetimer test expects 2026-08-01, and I get 2026-07-31. Both are one day off because I am in UTC-5, and those tests assume a European time zone.swagger.test.tsalso times out at 5s intermittently. None of them touch my change.One more thing worth knowing. While adding the skill branch, I found a separate bug in the same function:
language,districtandactivityall write the samedealkey, and object spread replaces rather than merges on a repeated key, so combining two of them silently drops one. Measured: one activity alone returns 1, and that same activity plus a language that does not apply still returns 1 instead of 0. It is ondevelopnow and unrelated to this feature.And when you test this: the skills dropdown depends on
/optionreturning skills. If an environment has nooptionrows withitem_type='skill', the accordion renders empty. My local database had none until I seeded them.Related Issues
Closes #905
Changes
skilladded toOpportunityCardsFilteranddefaultOpportunityCardsFilterskillFiltersincreateOpportunityFilterItems, plus the selected-filters flat arrayAccordionFilterinFiltersContent.tsxskillstranslation key in en and deScreenshots / Demos
Checklist