796: adds two new engagement types to NGO engagement - #923
796: adds two new engagement types to NGO engagement#923DarrellRoberts wants to merge 4 commits into
Conversation
ReviewNice, thorough coverage of the two new engagement types across labels, colors, and icons — and confirms this properly closes the Inconsistency between the two status-map files
[AgentEngagementStatusType.INCONTACT]: "var(--color-green-500)", // ChatsCircleIcon
[AgentEngagementStatusType.TRIED_TO_CONTACT]: "var(--color-grey-200)", // PhoneDisconnectIconBut [AgentEngagementStatusType.NEW]: "var(--color-green-100)", // SparkleIcon
[AgentEngagementStatusType.INCONTACT]: "var(--color-green-100)", // SparkleIcon
[AgentEngagementStatusType.TRIED_TO_CONTACT]: "var(--color-green-100)", // SparkleIconWherever this second file's maps are used (e.g. the Agents list/badges view, matching the "Badges" screenshot in the description), Nothing else stands out — translations read fine in both locales, and no other exhaustive |
Description
Adds two new engagement types to NGO engagement:
Currently blocked by
beas new values not expected inengagementStatusvalidationRelated Issues
Addresses #796
Changes
Screenshots / Demos
Badges
Modal
EN
DE
Checklist