weighted jaccard functions#3
Open
jefferis wants to merge 8 commits into
Open
Conversation
jefferis
commented
Apr 4, 2026
jefferis
commented
Collaborator
- brewing in coconat but wanted C++ versions for speed/memory reasons
- now suggests Matrix
jefferis
force-pushed
the
feature/weighted-jaccard
branch
from
6a1df1f to
cc7e20f
Compare
* this mean that it can be tested for equivalence * and rename both functions
* this should halve memory usage
* 4 threads are a good compromise in tests
c_weighted_jaccard_sparse() gains: - triangle=FALSE: return dgCMatrix (general) by default, dsCMatrix on TRUE - distance=TRUE: return 1 - similarity (with warning about densification) Companion changes: - importFrom(methods, as); methods added to Imports - expanded test coverage (+70 lines) - src/Makevars: replace $(shell Rscript ... RcppThread::LdFlags()) with $(SHLIB_OPENMP_CXXFLAGS) — drops GNU make extension flagged by R CMD check WARNING, while still pulling in pthread/OpenMP per platform
Use \link[Matrix:dgCMatrix-class]{dgCMatrix} in roxygen for the
hand-written R/weighted_jaccard.R and the cpp roxygen blocks in
src/weighted_jaccard.cpp, regenerating RcppExports and the .Rd files.
WORDLIST picks up the new spelling terms surfaced by spelling::spell_check_package().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.