Skip to content

Stop offering identity-provider sign-in in the installer - #224

Merged
rbardaji merged 1 commit into
mainfrom
fix/223-drop-oidc-prompt
Aug 4, 2026
Merged

Stop offering identity-provider sign-in in the installer#224
rbardaji merged 1 commit into
mainfrom
fix/223-drop-oidc-prompt

Conversation

@rbardaji

@rbardaji rbardaji commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Closes #223.

The installer asked whether to offer sign-in through the identity provider, then asked for a client id. No answer leads anywhere:

  • The clients a Federation registration creates are confidential (publicClient: False, client-secret authenticator), so the browser's code exchange is refused with unauthorized_client / "Invalid client or Invalid client credentials" — after a successful login, which reads as a credentials problem and is not one.
  • The platform's own client is confidential too, and its secret is not an Endpoint's to have.
  • Even with the exchange moved off the browser, the tokens these clients mint carry no sub claim, and AUTH_API_URL looks the user up by sub: it answers 500 {"error": "Failed to retrieve user details", "details": "Role query failed"}. Requesting the scope that would supply it answers invalid_scope, since it is assigned to those clients neither by default nor optionally.

So the question is removed. The prompts are now:

  Configuration id (blank to skip):
  Which local catalog should this Endpoint use?
  Register this Endpoint with the Federation now? [Y/n]:
  Organization name [My-Organization]:
  Endpoint name [my_endpoint]:
  Port to publish the Endpoint on [8003]:
  Authentication service (AAI) URL [...]:

The OIDC_* settings are untouched: still documented in example.env and docs/configuration.md, still read by the API and the UI. A deployment that has a working client switches sign-in on by editing .env; the installer simply never turns it on. install/README.md now says why, in place of the older explanation that no longer describes the real obstacle.

Verified

  • An interactive run driven through a pty asks the seven questions above and no more, and renders OIDC_ENABLED=False.
  • 1204 tests, black --check . and flake8 clean.

The installer asked whether to offer sign-in through the identity provider and
then asked for a client id, but there is no client an Endpoint can use. The
ones a Federation registration creates are confidential, so the browser's code
exchange is refused with 'Invalid client or Invalid client credentials', and
their tokens carry no sub claim — which AUTH_API_URL looks the user up by, so
validation answers 500 even once the exchange succeeds. The scope that
supplies sub is assigned to those clients neither by default nor optionally,
so nothing the Endpoint requests can add it.

Answering yes could only produce a button that fails after a successful login,
which reads as a credentials problem and is not one. The question goes until
how this is meant to work is settled with whoever administers the identity
provider.

The OIDC_* settings stay documented and are still read by the API and the UI,
so a deployment with a working client switches sign-in on by editing .env.
@rbardaji
rbardaji merged commit 4326c85 into main Aug 4, 2026
1 check passed
@rbardaji
rbardaji deleted the fix/223-drop-oidc-prompt branch August 4, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The installer offers identity-provider sign-in, which cannot work

1 participant