Build the image from the checkout being installed - #222
Merged
Conversation
The stack was started with 'compose up -d', which builds only when no image exists. On a machine that had run an Endpoint before, the container came back from the image built the first time and the checkout was never compiled in: the install reported success while running old code, a route added since answered 404, and the UI served was the one built weeks earlier. Meanwhile .env, rendered on every run, was current — so the mismatch read as a configuration problem. Started with --build now, as the CKAN stack already was. Unchanged sources come from the layer cache.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #221.
The installer starts the stack with
docker compose up -d, which builds an image only when none exists. On any machine that has run an Endpoint before, the container is recreated from the image built the first time and the current checkout is never compiled in.The install reports success while running old code. It stays invisible until something depends on a change — a route added since answers 404, and the UI served is the one built then — and
.env, regenerated on every run, is current, so the mismatch reads as a configuration problem rather than a stale build. This cost a full debugging session on an Endpoint that was running an image two weeks old.Started with
--buildnow, which is what the installer already does for the CKAN stack. Unchanged sources come from the layer cache, so the cost after the first run is small, and the step says the first build takes a few minutes.Verified
/openapi.jsondid not contain the route and the container kept serving the older UI; after--build, the route is present and answers.compose upfor the Endpoint carries--build.black --check .clean.