fix(issue): support haproxy external ingress priority detection#465
Open
ybelMekk wants to merge 30 commits into
Open
fix(issue): support haproxy external ingress priority detection#465ybelMekk wants to merge 30 commits into
ybelMekk wants to merge 30 commits into
Conversation
…checker - Add priorityActNow, priorityHigh, priorityElevated, priorityMonitor fields to ImageVulnerabilitySummary model - Expose priority fields in vulnerability.graphqls and GraphQL resolvers - Add VULNERABILITY_PRIORITY_ACT_NOW and VULNERABILITY_PRIORITY_HIGH sort fields - Add ExternalIngressActNowVulnerabilityIssue type and issue checker - Map priority signals (EPSS, KEV, ransomware) via VulnerabilityPrioritySignals - Bump golang.org/x/net to v0.55.0 and golang.org/x/crypto to v0.52.0 to fix known vulnerabilities - Update v13s/pkg/api to v0.0.0-20260525171357-13563f32226d (priority_elevated, priority_monitor support)
…; fix ExternalIngressActNow resolver stubs; add priority sort fields
…rebase onto main)
…ounts for terminal states
…ier to ImageVulnerabilitySummary
ybelMekk
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the issue checker’s logic for detecting externally exposed ingresses by reusing the shared ingress class mapping from the workload/application domain, ensuring HAProxy external ingress classes are correctly treated as external exposure.
Changes:
- Added
application.IsIngressClassExternallyExposedto centralize “external exposure” detection (including authenticated external classes). - Updated v13s workload issue detection to use the shared mapping instead of a single hardcoded ingress class name.
- Expanded test coverage and testdata to cover legacy external, external HAProxy, authenticated external HAProxy, and non-external/unknown/missing ingress classes.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/workload/application/ingress_class_mapping.go | Adds exported helper to determine whether an ingress class is externally exposed. |
| internal/issue/checker/workload_v13s.go | Switches external ingress detection to use the shared helper (supports HAProxy external classes). |
| internal/issue/checker/workload_v13s_test.go | Parameterizes and expands the external-ingress critical vulnerability test matrix. |
| internal/issue/checker/testdata/dev-gcp/devteam/apps.yaml | Updates/extends test fixtures for various ingress class scenarios. |
Contributor
Author
|
Waiting for #452 to merge first, since this PR is based on that branch and should be merged afterwards. |
ybelMekk
force-pushed
the
feat/cve-priority
branch
from
4277e04 to
fd27b92
Compare
ybelMekk
force-pushed
the
feat/cve-priority
branch
from
8dc6401 to
7576a8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Test