Skip to content

feat: refactor device tier computation into DeviceSpec extension with test - #37

Open
mwshubham wants to merge 2 commits into
mainfrom
dev
Open

feat: refactor device tier computation into DeviceSpec extension with test#37
mwshubham wants to merge 2 commits into
mainfrom
dev

Conversation

@mwshubham

Copy link
Copy Markdown
Owner

feat: refactor device tier computation into DeviceSpec extension function and added test for extension function

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

Compose Compiler Stability

Metric Count
✅ Restartable & skippable composables 316
✅ Restartable but NOT skippable 0
Total restartable composables 316
✅ Stable classes 336
⚠️ Unstable classes 147

Reports uploaded as the compose-compiler-reports artifact.

@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.57%. Comparing base (578d7ad) to head (06fef9e).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...resentation/viewmodel/DeviceClassifierViewModel.kt 60.00% 2 Missing and 2 partials ⚠️

❌ Your patch check has failed because the patch coverage (60.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #37      +/-   ##
============================================
- Coverage     53.65%   53.57%   -0.09%     
+ Complexity      397      391       -6     
============================================
  Files           249      248       -1     
  Lines          9274     9266       -8     
  Branches        767      763       -4     
============================================
- Hits           4976     4964      -12     
- Misses         4023     4025       +2     
- Partials        275      277       +2     
Flag Coverage Δ
unit-tests 53.57% <60.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...resentation/viewmodel/DeviceClassifierViewModel.kt 90.19% <60.00%> (-7.64%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

Copy link
Copy Markdown
Contributor

❌ Screenshot Tests Failed

One or more Composables no longer match their golden images.

Failing tests:

  • MessageLogListTest > withMessages FAILED

📊 Download the screenshot-reports artifact for the full before/after/diff HTML report.

To update goldens locally, run:

./gradlew :feature:tic-tac-toe:impl:recordPaparazziDebug
./gradlew :feature:note:impl:recordPaparazziDebug
./gradlew :feature:media-orchestrator:impl:recordPaparazziDebug
./gradlew :feature:sse:impl:recordPaparazziDebug

Then commit the updated PNGs in src/test/snapshots/images/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant