Skip to content

Stop logging the plaintext password on a failed login #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgrossmann merged 1 commit into from
Jul 6, 2026
Merged

Stop logging the plaintext password on a failed login #117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions credentials/src/credlin.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,12 @@ cred_login(unsigned addr, unsigned char *userid, unsigned char *password)
cred = cred_find_by_token(&tok);
if (cred) goto cleanup;

/* attempt to login via racf interface */
/* attempt to login via racf interface. On failure RAKF already writes its
own RAKF0004 audit message, so we do NOT log here -- an httpd message
would only duplicate it, and logging the attempted password (pass) would
leak a plaintext credential to the console/SYSLOG (issue #116). */
acee = racf_login(user, pass, 0, &rc);
if (!acee) {
wtof("%s: racf_login(\"%s\", \"%s\") failed, rc=%d",
__func__, user, pass, rc);
goto cleanup;
}

Expand Down