Skip to content

Update Bravura to 1.481 - #34489

Open
Jojo-Schmitz wants to merge 1 commit into
musescore:mainfrom
Jojo-Schmitz:bravura
Open

Update Bravura to 1.481#34489
Jojo-Schmitz wants to merge 1 commit into
musescore:mainfrom
Jojo-Schmitz:bravura

Conversation

@Jojo-Schmitz

@Jojo-Schmitz Jojo-Schmitz commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

which got released just today (7Aug26)

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Updated Bravura and Bravura Text release history through versions 1.480 and 1.481. Refreshed licensing, SMuFL references, repository links, support guidance, and Unicode-input instructions. Updated Bravura Text documentation to version 1.2 dated 6 August 2026. Changed the bundled font resource mapping to use Bravura.json for metadata.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description contains only a brief release-date note and omits the required issue reference, motivation, and checklist. Add the issue reference, a short change summary and motivation, and complete each applicable checklist item.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: updating Bravura to version 1.481.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Linked repositories: Public OSS repositories can only analyze public repositories installed in this organization. No linked repositories were analyzed; skipped musescore/muse_framework.git.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@fonts/bravura/FONTLOG.txt`:
- Line 486: Update the changelog entry for noteheadDiamondDoubleWhole and
noteheadDiamondWhole to use the past-tense “Improved” instead of “Improve,”
matching the surrounding completed-change entries.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 413437be-0efc-44da-af7f-70b456963dd4

📥 Commits

Reviewing files that changed from the base of the PR and between f4cdc6b and 9ce5375.

⛔ Files ignored due to path filters (2)
  • fonts/bravura/Bravura.otf is excluded by !**/*.otf
  • fonts/bravura/BravuraText.otf is excluded by !**/*.otf
📒 Files selected for processing (4)
  • fonts/bravura/FONTLOG.txt
  • fonts/bravura/LICENSE.txt
  • fonts/bravura/README.md
  • fonts/bravura/bravura_metadata.json

Comment thread fonts/bravura/FONTLOG.txt
@Jojo-Schmitz

Jojo-Schmitz commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

The vtest differences are very minimal, as far as I can tell, except for this (just updated for 1.481):
bravura-10-1 diff
(fallback to Bravura apparently)
emmentaler-10-1 diff
(fallback to Bravura apparently)
gonville-10-1 diff
(fallback to Bravura apparently)
musejazz-10-1 diff
IMHO for the better (larger diamond heads)

@Jojo-Schmitz Jojo-Schmitz changed the title Update Bravura to 1.49 Update Bravura to 1.480 Aug 7, 2026
@Jojo-Schmitz
Jojo-Schmitz marked this pull request as draft August 7, 2026 08:58
@Jojo-Schmitz
Jojo-Schmitz marked this pull request as ready for review August 7, 2026 09:02
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

Comment thread src/engraving/data/fonts/fonts_Bravura.qrc
@Jojo-Schmitz

Jojo-Schmitz commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

I guess we can go to 1.481 now, which got released a couple minutes ago. Or just wait a little longer, util the dust settles, seems Daniel Spreadbury is heavily working on Bravura ATM

@Jojo-Schmitz
Jojo-Schmitz marked this pull request as draft August 7, 2026 17:29
@Jojo-Schmitz
Jojo-Schmitz marked this pull request as ready for review August 7, 2026 17:32
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@Jojo-Schmitz Jojo-Schmitz changed the title Update Bravura to 1.480 Update Bravura to 1.481 Aug 7, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@fonts/bravura/bravura-text.md`:
- Line 57: Update the navigation terminology in the paragraph: use the current
macOS path “System Settings → Keyboard → Keyboard Shortcuts → Input Sources”
instead of the legacy pane/tab wording, and replace “OS X” with “macOS”;
preserve the shortcut instructions and examples.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 56eb6384-2139-445b-ae39-751cd359879c

📥 Commits

Reviewing files that changed from the base of the PR and between 106e63b and d7c0731.

⛔ Files ignored due to path filters (2)
  • fonts/bravura/Bravura.otf is excluded by !**/*.otf
  • fonts/bravura/BravuraText.otf is excluded by !**/*.otf
📒 Files selected for processing (7)
  • fonts/bravura/Bravura.json
  • fonts/bravura/FONTLOG.txt
  • fonts/bravura/LICENSE.txt
  • fonts/bravura/README.md
  • fonts/bravura/bravura-text.md
  • fonts/bravura/bravura_metadata.json
  • src/engraving/data/fonts/fonts_Bravura.qrc
🚧 Files skipped from review as they are similar to previous changes (3)
  • fonts/bravura/README.md
  • fonts/bravura/LICENSE.txt
  • src/engraving/data/fonts/fonts_Bravura.qrc

Comment thread fonts/bravura/bravura-text.md
@mathesoncalum
mathesoncalum requested a review from miiizen August 10, 2026 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants