Skip to content

Organ pedal marks - #23504

Closed
PetJer wants to merge 5 commits into
musescore:mainfrom
PetJer:organ-pedal-marks
Closed

Organ pedal marks#23504
PetJer wants to merge 5 commits into
musescore:mainfrom
PetJer:organ-pedal-marks

Conversation

@PetJer

@PetJer PetJer commented Jul 8, 2024

Copy link
Copy Markdown

This is a PR for organ pedal marks.

  • Organ palette with symbols
  • Popup
  • Input mode
pedal-marks-drop pedal-marks-input-mode pedal-marks-keyboard-input

Known issues:

  • Selecting a note and applying a pedal mark from the palette opens popup in wrong position
  • "Side-of-foot" not having the right offset (because it doesn't collide with the note beam)
  • Layout doesn't work on other voices than voice 1
  • Wrong accessibility name

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

PetJer added 5 commits July 8, 2024 08:56
Add ability to change mark from popup
Set default input position to below staff
@PetJer
PetJer force-pushed the organ-pedal-marks branch from 1dc01c6 to 54b07e5 Compare July 8, 2024 10:03
Comment on lines +2313 to +2314
|| e->isDynamic()
|| e->isExpression()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mike-spa may want to check these two additions :)


muse::TranslatableString OrganPedalMark::typeUserName() const
{
return TranslatableString("engraving/sym", SymNames::translatedUserNameForSymId(symId()));

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be changed to be more in accordance with PR #20850 (see especially Articulation)

@rettinghaus

Copy link
Copy Markdown
Contributor

@PetJer any updates on this?

@PetJer

PetJer commented Feb 16, 2025

Copy link
Copy Markdown
Author

@rettinghaus

There was no progress since September. I'm in touch with the team, so right now I'm waiting for the designs (it's not a priority feature, so it's understandable). I'll continue with the work in late June, when I hope the designs will be ready.

FYI @avvvvve

@bkunda

bkunda commented Nov 4, 2025

Copy link
Copy Markdown

@PetJer we're interested in re-reviewing this PR if you're still available and keen to work on it again.

It will need a rebase before we're able to review it: is this something you're able to do?

I do have a couple of questions:

  1. Popups always cause additional headaches from an implementation POV. For an MVP of this feature, what do you think about creating just the dedicated palette of symbols?
  2. I admit I don't know much about what these symbols are supposed to denote: are there any playback implications the user might expect from these instructions?

@PetJer

PetJer commented Nov 4, 2025

Copy link
Copy Markdown
Author

@bkunda I'm keen on working on the project, but I won't be able to work on it until summer.

  1. I think creating a dedicated palette with the following SMuFL symbols: keyboardPedalToe2, keyboardPedalToe1, keyboardPedalHeel1, keyboardPedalHeel2, keyboardPedalHeel3; is the bottom-line for this feature. My implementation (that is essentially a copy of the fingering system) placed the mentioned symbols as intended (they should be downscaled). From here it's a matter of debate if this is an MVP, but I expect that this implementation should accommodate the basic needs for the majority of users.
  2. This symbols are treated as "fingering" for the feet and there are no playback implications.

The mentioned bottom-line shouldn't be too difficult to implement for anyone who knows the codebase well. If someone decides to tackle this feature before me, I'm open to give feedback (better to make another PR then).

@igorkorsukov
igorkorsukov changed the base branch from master to main May 14, 2026 14:37
@PetJer

PetJer commented Aug 9, 2026

Copy link
Copy Markdown
Author

Followed by #34517.

@PetJer PetJer closed this Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants