Organ pedal marks - #23504
Conversation
| || e->isDynamic() | ||
| || e->isExpression() |
There was a problem hiding this comment.
@mike-spa may want to check these two additions :)
|
|
||
| muse::TranslatableString OrganPedalMark::typeUserName() const | ||
| { | ||
| return TranslatableString("engraving/sym", SymNames::translatedUserNameForSymId(symId())); |
There was a problem hiding this comment.
This should probably be changed to be more in accordance with PR #20850 (see especially Articulation)
|
@PetJer any updates on this? |
|
There was no progress since September. I'm in touch with the team, so right now I'm waiting for the designs (it's not a priority feature, so it's understandable). I'll continue with the work in late June, when I hope the designs will be ready. FYI @avvvvve |
|
@PetJer we're interested in re-reviewing this PR if you're still available and keen to work on it again. It will need a rebase before we're able to review it: is this something you're able to do? I do have a couple of questions:
|
|
@bkunda I'm keen on working on the project, but I won't be able to work on it until summer.
The mentioned bottom-line shouldn't be too difficult to implement for anyone who knows the codebase well. If someone decides to tackle this feature before me, I'm open to give feedback (better to make another PR then). |
|
Followed by #34517. |
This is a PR for organ pedal marks.
Known issues: