Skip to content

RoguePlot(): guard preorder assertion against missing "order" attribute #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ms609 merged 2 commits into from
Jul 27, 2026
Merged

RoguePlot(): guard preorder assertion against missing "order" attribute #277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
859e7cd
RoguePlot(): guard preorder assertion against missing "order" attribute
ms609 Jul 24, 2026
199a9c0
req testthat v
ms609 Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion R/RoguePlot.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ RoguePlot <- function(trees, tip, p = 1, plot = TRUE,
if (isTRUE(sort)) {
cons <- DropTip(cons, dummyRoot, preorder = FALSE, check = FALSE)
} else {
stopifnot(attr(cons, "order") == "preorder")
stopifnot(identical(attr(cons, "order"), "preorder"))
# We promise to return `cons` in preorder
cons <- DropTip(cons, dummyRoot, preorder = TRUE, check = FALSE)
}
Expand Down
15 changes: 15 additions & 0 deletions tests/testthat/test-RoguePlot.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,21 @@ test_that("RoguePlot(sort = TRUE)", {
expect_equal(sorted$atNode, unsorted$atNode)
})

test_that("RoguePlot() errors cleanly if cons loses its preorder attribute", {
skip_if_not_installed("testthat", "3.1.7") # for local_mocked_bindings()
trees <- list(read.tree(text = "(a, (b, (c, (rogue, (d, e)))));"),
read.tree(text = "(a, (b, (c, ((d, e), rogue))));"))
local_mocked_bindings(
Preorder = function(tree, ...) {
attr(tree, "order") <- NULL
tree
},
.package = "TreeTools"
)
expect_error(RoguePlot(trees, tip = "rogue", plot = FALSE),
"preorder")
})

test_that("polytomy id", {
trees <- list(read.tree(text = "(a,(((b,(c,d)),e),rogue));"),
read.tree(text = "(a,((((c,d),e),rogue),b));"),
Expand Down
Loading