Skip to content

Base-scenario-first phased generation - #88

Merged
mrwadams merged 2 commits into
mainfrom
agent/issue-48
Aug 13, 2026
Merged

Base-scenario-first phased generation#88
mrwadams merged 2 commits into
mainfrom
agent/issue-48

Conversation

@mrwadams

Copy link
Copy Markdown
Owner

Automated by agent-loop — pi worked this issue on a fresh clone of mrwadams/attackgen; changes were gated outside the agent on agent-1.

Closes #48

How to test

git fetch origin && git checkout agent/issue-48
python3 -m venv .venv && . .venv/bin/activate
pip install -r requirements.txt
streamlit run "00_👋_Welcome.py"

Then open the printed local URL.

Confirm each acceptance criterion:

  • The base scenario, base download, and Navigator layer become available as soon as the base stream completes, while an optional narrative is still generating
  • The Assistant handoff is set from the base result and does not wait for the optional narrative
  • An input snapshot is captured at Generate press; rendering and downloads use the snapshot, not mutable current widgets
  • The active phase and elapsed time are visible during generation; duration messaging acknowledges multi-minute runs
  • Coordinator tests cover the phase sequence, base-result persistence before optional enrichment, captured-input metadata, and streamed partial-text visibility using a controllable streaming fixture

Gates (non-authoritative)

  • files_non_empty — 5 non-empty file(s) changed
  • containment — diff stays within the allowed lane
  • verify — pytest: 246 passed, no failures (browser/e2e excluded)

Draft. Browser/e2e tests were NOT run in-gate — run them and review before merging. Nothing here is auto-merged.

agent-loop and others added 2 commits August 11, 2026 09:11
Implements #48 (agent-loop / pi).
The narrative is a second model call whose elapsed label only advances as
chunks arrive. Reasoning models can spend minutes on it before emitting any
text, so the counter freezes and a live spinner next to a static "elapsed"
reads as a hang. Say the wait is expected in the status line; a genuine
live-ticking timer needs the model call moved off the main thread and is
tracked separately.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PLMCkJWBD37DojRkPcyTRh
@mrwadams
mrwadams marked this pull request as ready for review August 13, 2026 08:52
@mrwadams
mrwadams merged commit 302d4ef into main Aug 13, 2026
12 checks passed
@mrwadams
mrwadams deleted the agent/issue-48 branch August 13, 2026 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Base-scenario-first phased generation

2 participants