Skip to content

fix: lower PAGE_VIEW_CAPTURE_FAILED severity from WARNING to INFO #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexs-mparticle merged 1 commit into from
Aug 5, 2026
Merged

fix: lower PAGE_VIEW_CAPTURE_FAILED severity from WARNING to INFO #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Rokt-Kit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -932,7 +932,7 @@ class RoktKit implements KitInterface {
this.errorReportingService?.report({
message: `Rokt Kit: Failed to capture page view for ${pageUrl}`,
code: 'PAGE_VIEW_CAPTURE_FAILED',
severity: WSDKErrorSeverity.WARNING,
severity: WSDKErrorSeverity.INFO,
stackTrace: err instanceof Error ? err.stack : undefined,
});
}
Expand Down Expand Up @@ -1222,7 +1222,7 @@ class RoktKit implements KitInterface {
this.errorReportingService?.report({
message: 'Rokt Kit: Failed to clear page views when targeting is disabled',
code: 'PAGE_VIEW_CAPTURE_FAILED',
severity: WSDKErrorSeverity.WARNING,
severity: WSDKErrorSeverity.INFO,
stackTrace: err instanceof Error ? err.stack : undefined,
});
}
Expand Down Expand Up @@ -1311,7 +1311,7 @@ class RoktKit implements KitInterface {
this.errorReportingService?.report({
message: 'Rokt Kit: Failed to clear page views on session end',
code: 'PAGE_VIEW_CAPTURE_FAILED',
severity: WSDKErrorSeverity.WARNING,
severity: WSDKErrorSeverity.INFO,
stackTrace: err instanceof Error ? err.stack : undefined,
});
}
Expand Down
4 changes: 2 additions & 2 deletions test/src/tests.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5905,9 +5905,9 @@ describe('Rokt Forwarder', () => {

// Nothing is persisted, but the forwarder keeps running.
expect(readStoredPageViews()).toBeNull();
// The write failure is surfaced as a WARNING.
// The write failure is surfaced as an INFO (rate-limited per severity).
expect(reportSpy).toHaveBeenCalledWith(
expect.objectContaining({ code: 'PAGE_VIEW_CAPTURE_FAILED', severity: 'WARNING' }),
expect.objectContaining({ code: 'PAGE_VIEW_CAPTURE_FAILED', severity: 'INFO' }),
);
reportSpy.mockRestore();
});
Expand Down
Loading