Skip to content

refactor: rename timeOnPage to activeTimeOnPage in selectPlacements page_events #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexs-mparticle merged 1 commit into from
Aug 5, 2026
+16 −16
Merged

refactor: rename timeOnPage to activeTimeOnPage in selectPlacements page_events #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Rokt-Kit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ interface PageEvent {
// Derived at transmission not at capture based
// on the next page view's activeTimeOnSite,
// so it is absent on stored records.
timeOnPage?: number;
activeTimeOnPage?: number;
}

interface RoktSelection {
Expand Down Expand Up @@ -983,7 +983,7 @@ class RoktKit implements KitInterface {
if (hasActiveTime && hasNextActiveTimeOnSite) {
const diff = nextActiveTimeOnSite - activeTimeOnSite;
if (diff >= 0) {
pageEvent.timeOnPage = diff;
pageEvent.activeTimeOnPage = diff;
}
}
return pageEvent;
Expand Down
28 changes: 14 additions & 14 deletions test/src/tests.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6011,7 +6011,7 @@ describe('Rokt Forwarder', () => {
expect(forwardedAttributes.mpPageViews).toBeUndefined();
});

it('surfaces timeOnPage as the active-time diff to the next page view', async () => {
it('surfaces activeTimeOnPage as the active-time diff to the next page view', async () => {
await (window as any).mParticle.forwarder.init(
{
accountId: '123456',
Expand Down Expand Up @@ -6046,14 +6046,14 @@ describe('Rokt Forwarder', () => {

const forwardedAttributes = (window as any).mParticle.Rokt.selectPlacementsOptions.attributes;
// First page's time-on-page is how long it was viewed before the next page:
// 4200 - 1000 = 3200. The last (still-open) page has no timeOnPage.
// 4200 - 1000 = 3200. The last (still-open) page has no activeTimeOnPage.
expect(JSON.parse(forwardedAttributes.page_events)).toEqual([
{
pageUrl: window.location.href,
sourceMessageId: 'source-message-id-7',
timestamp: 1712345678000,
activeTimeOnSite: 1000,
timeOnPage: 3200,
activeTimeOnPage: 3200,
},
{
pageUrl: window.location.href,
Expand All @@ -6064,7 +6064,7 @@ describe('Rokt Forwarder', () => {
]);
});

it('computes a consecutive timeOnPage diff for each non-last page view', async () => {
it('computes a consecutive activeTimeOnPage diff for each non-last page view', async () => {
await (window as any).mParticle.forwarder.init(
{
accountId: '123456',
Expand Down Expand Up @@ -6107,12 +6107,12 @@ describe('Rokt Forwarder', () => {

const forwardedAttributes = (window as any).mParticle.Rokt.selectPlacementsOptions.attributes;
const pageEvents = JSON.parse(forwardedAttributes.page_events);
expect(pageEvents[0].timeOnPage).toBe(1500); // 2500 - 1000
expect(pageEvents[1].timeOnPage).toBe(6500); // 9000 - 2500
expect(pageEvents[2].timeOnPage).toBeUndefined(); // still open
expect(pageEvents[0].activeTimeOnPage).toBe(1500); // 2500 - 1000
expect(pageEvents[1].activeTimeOnPage).toBe(6500); // 9000 - 2500
expect(pageEvents[2].activeTimeOnPage).toBeUndefined(); // still open
});

it('omits timeOnPage when the active-time diff would be negative', async () => {
it('omits activeTimeOnPage when the active-time diff would be negative', async () => {
await (window as any).mParticle.forwarder.init(
{
accountId: '123456',
Expand Down Expand Up @@ -6148,11 +6148,11 @@ describe('Rokt Forwarder', () => {
const forwardedAttributes = (window as any).mParticle.Rokt.selectPlacementsOptions.attributes;
const pageEvents = JSON.parse(forwardedAttributes.page_events);
// 1000 - 5000 = -4000 → omitted rather than emitting a misleading value.
expect(pageEvents[0].timeOnPage).toBeUndefined();
expect(pageEvents[1].timeOnPage).toBeUndefined();
expect(pageEvents[0].activeTimeOnPage).toBeUndefined();
expect(pageEvents[1].activeTimeOnPage).toBeUndefined();
});

it('does not fabricate a timeOnPage when a record is missing activeTimeOnSite', async () => {
it('does not fabricate an activeTimeOnPage when a record is missing activeTimeOnSite', async () => {
// Seed a record with no activeTimeOnSite (the non-finite-source case)
// followed by one that has it. A coerced-to-0 first record would diff
// against the next (300000 - 0) and invent a 5-minute dwell that never
Expand Down Expand Up @@ -6193,10 +6193,10 @@ describe('Rokt Forwarder', () => {
const pageEvents = JSON.parse(forwardedAttributes.page_events);
// First record has no activeTimeOnSite and therefore no derived dwell time.
expect(pageEvents[0].activeTimeOnSite).toBeUndefined();
expect(pageEvents[0].timeOnPage).toBeUndefined();
// Second record keeps its finite value; still-open so no timeOnPage.
expect(pageEvents[0].activeTimeOnPage).toBeUndefined();
// Second record keeps its finite value; still-open so no activeTimeOnPage.
expect(pageEvents[1].activeTimeOnSite).toBe(300000);
expect(pageEvents[1].timeOnPage).toBeUndefined();
expect(pageEvents[1].activeTimeOnPage).toBeUndefined();
});

it('clears stored page views on init when targeting is disabled', async () => {
Expand Down
Loading